Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js

Issue 2890863003: DevTools/Coverage: filter out content scripts (Closed)
Patch Set: DevTools/Coverage: filter out content scripts Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
index fcbd1ff86ce0263380e79eac3be2b58cd893935c..9ee062b6f97c6dc4af9a36079887b5d3122b0f33 100644
--- a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
+++ b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
@@ -3,15 +3,19 @@
// found in the LICENSE file.
Coverage.CoverageListView = class extends UI.VBox {
- constructor() {
+ /**
+ * @param {function(!Coverage.URLCoverageInfo):boolean} filterCallback
+ */
+ constructor(filterCallback) {
super(true);
/** @type {!Map<!Coverage.URLCoverageInfo, !Coverage.CoverageListView.GridNode>} */
this._nodeForCoverageInfo = new Map();
+ this._filterCallback = filterCallback;
/** @type {?RegExp} */
- this._filterRegExp = null;
+ this._highlightRegExp = null;
this.registerRequiredCSS('coverage/coverageListView.css');
var columns = [
- {id: 'url', title: Common.UIString('URL'), width: '300px', fixedWidth: false, sortable: true},
+ {id: 'url', title: Common.UIString('URL'), width: '250px', fixedWidth: false, sortable: true},
{id: 'type', title: Common.UIString('Type'), width: '45px', fixedWidth: true, sortable: true}, {
id: 'size',
title: Common.UIString('Total Bytes'),
@@ -23,13 +27,13 @@ Coverage.CoverageListView = class extends UI.VBox {
{
id: 'unusedSize',
title: Common.UIString('Unused Bytes'),
- width: '60px',
+ width: '100px',
fixedWidth: true,
sortable: true,
align: DataGrid.DataGrid.Align.Right,
sort: DataGrid.DataGrid.Order.Descending
},
- {id: 'bars', title: '', width: '500px', fixedWidth: false, sortable: true}
+ {id: 'bars', title: '', width: '250px', fixedWidth: false, sortable: true}
];
this._dataGrid = new DataGrid.SortableDataGrid(columns);
this._dataGrid.setResizeMethod(DataGrid.DataGrid.ResizeMethod.Last);
@@ -52,13 +56,13 @@ Coverage.CoverageListView = class extends UI.VBox {
for (var entry of coverageInfo) {
var node = this._nodeForCoverageInfo.get(entry);
if (node) {
- if (this._isVisible(node))
+ if (this._filterCallback(node._coverageInfo))
hadUpdates = node._refreshIfNeeded(maxSize) || hadUpdates;
continue;
}
node = new Coverage.CoverageListView.GridNode(entry, maxSize);
this._nodeForCoverageInfo.set(entry, node);
- if (this._isVisible(node)) {
+ if (this._filterCallback(node._coverageInfo)) {
rootNode.appendChild(node);
hadUpdates = true;
}
@@ -73,16 +77,16 @@ Coverage.CoverageListView = class extends UI.VBox {
}
/**
- * @param {?RegExp} regExp
+ * @param {?RegExp} highlightRegExp
*/
- setFilter(regExp) {
- this._filterRegExp = regExp;
+ updateFilterAndHighlight(highlightRegExp) {
+ this._highlightRegExp = highlightRegExp;
var hadTreeUpdates = false;
for (var node of this._nodeForCoverageInfo.values()) {
- var shouldBeVisible = this._isVisible(node);
+ var shouldBeVisible = this._filterCallback(node._coverageInfo);
var isVisible = !!node.parent;
if (shouldBeVisible)
- node._setHighlight(regExp);
+ node._setHighlight(this._highlightRegExp);
if (shouldBeVisible === isVisible)
continue;
hadTreeUpdates = true;
@@ -104,14 +108,6 @@ Coverage.CoverageListView = class extends UI.VBox {
}
/**
- * @param {!Coverage.CoverageListView.GridNode} node
- * @return {boolean}
- */
- _isVisible(node) {
- return !this._filterRegExp || this._filterRegExp.test(node._url);
- }
-
- /**
* @param {!Event} event
*/
_onKeyDown(event) {
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698