DevTools/Coverage: filter out content scripts

third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js

 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Coverage.CoverageListView = class extends UI.VBox {
-  constructor() {
+  /**
+   * @param {function(!Coverage.URLCoverageInfo):boolean} filterCallback
+   */
+  constructor(filterCallback) {
     super(true);
     /** @type {!Map<!Coverage.URLCoverageInfo, !Coverage.CoverageListView.GridNode>} */
     this._nodeForCoverageInfo = new Map();
+    /** @type {function(!Coverage.URLCoverageInfo):boolean} */

[alph, 2017/05/18 01:02:31]

no need to annotate

+    this._filterCallback = filterCallback;
     /** @type {?RegExp} */
-    this._filterRegExp = null;
+    this._highlightRegExp = null;
     this.registerRequiredCSS('coverage/coverageListView.css');
     var columns = [
-      {id: 'url', title: Common.UIString('URL'), width: '300px', fixedWidth: false, sortable: true},
+      {id: 'url', title: Common.UIString('URL'), width: '250px', fixedWidth: false, sortable: true},
       {id: 'type', title: Common.UIString('Type'), width: '45px', fixedWidth: true, sortable: true}, {
         id: 'size',
         title: Common.UIString('Total Bytes'),
         width: '60px',
         fixedWidth: true,
         sortable: true,
         align: DataGrid.DataGrid.Align.Right
       },
       {
         id: 'unusedSize',
         title: Common.UIString('Unused Bytes'),
-        width: '60px',
+        width: '100px',
         fixedWidth: true,
         sortable: true,
         align: DataGrid.DataGrid.Align.Right,
         sort: DataGrid.DataGrid.Order.Descending
       },
-      {id: 'bars', title: '', width: '500px', fixedWidth: false, sortable: true}
+      {id: 'bars', title: '', width: '250px', fixedWidth: false, sortable: true}
     ];
     this._dataGrid = new DataGrid.SortableDataGrid(columns);
     this._dataGrid.setResizeMethod(DataGrid.DataGrid.ResizeMethod.Last);
     this._dataGrid.element.classList.add('flex-auto');
     this._dataGrid.element.addEventListener('keydown', this._onKeyDown.bind(this), false);
     this._dataGrid.addEventListener(DataGrid.DataGrid.Events.OpenedNode, this._onOpenedNode, this);
     this._dataGrid.addEventListener(DataGrid.DataGrid.Events.SortingChanged, this._sortingChanged, this);
 
     var dataGridWidget = this._dataGrid.asWidget();
     dataGridWidget.show(this.contentElement);
   }
 
   /**
    * @param {!Array<!Coverage.URLCoverageInfo>} coverageInfo
    */
   update(coverageInfo) {
     var hadUpdates = false;
     var maxSize = coverageInfo.reduce((acc, entry) => Math.max(acc, entry.size()), 0);
     var rootNode = this._dataGrid.rootNode();
     for (var entry of coverageInfo) {
       var node = this._nodeForCoverageInfo.get(entry);
       if (node) {
-        if (this._isVisible(node))
+        if (this._filterCallback(node._coverageInfo))
           hadUpdates = node._refreshIfNeeded(maxSize) || hadUpdates;
         continue;
       }
       node = new Coverage.CoverageListView.GridNode(entry, maxSize);
       this._nodeForCoverageInfo.set(entry, node);
-      if (this._isVisible(node)) {
+      if (this._filterCallback(node._coverageInfo)) {
         rootNode.appendChild(node);
         hadUpdates = true;
       }
     }
     if (hadUpdates)
       this._sortingChanged();
   }
 
   reset() {
     this._nodeForCoverageInfo.clear();
     this._dataGrid.rootNode().removeChildren();
   }
 
   /**
-   * @param {?RegExp} regExp
+   * @param {?RegExp} highlightRegExp
    */
-  setFilter(regExp) {
-    this._filterRegExp = regExp;
+  updateFilterAndHighlight(highlightRegExp) {
+    this._highlightRegExp = highlightRegExp;
     var hadTreeUpdates = false;
     for (var node of this._nodeForCoverageInfo.values()) {
-      var shouldBeVisible = this._isVisible(node);
+      var shouldBeVisible = this._filterCallback(node._coverageInfo);
       var isVisible = !!node.parent;
       if (shouldBeVisible)
-        node._setHighlight(regExp);
+        node._setHighlight(this._highlightRegExp);
       if (shouldBeVisible === isVisible)
         continue;
       hadTreeUpdates = true;
       if (!shouldBeVisible)
         node.remove();
       else
         this._dataGrid.rootNode().appendChild(node);
     }
     if (hadTreeUpdates)
       this._sortingChanged();
   }
 
   /**
    * @param {!Common.Event} event
    */
   _onOpenedNode(event) {
     var node = /** @type Coverage.CoverageListView.GridNode */ (event.data);
     this._revealSourceForNode(node);
   }
 
   /**
-   * @param {!Coverage.CoverageListView.GridNode} node
-   * @return {boolean}
-   */
-  _isVisible(node) {
-    return !this._filterRegExp || this._filterRegExp.test(node._url);
-  }
-
-  /**
    * @param {!Event} event
    */
   _onKeyDown(event) {
     if (!isEnterKey(event))
       return;
     event.consume(true);
     this._revealSourceForNode(this._dataGrid.selectedNode);
   }
 
   /**
@@ skipping 180 matching lines @@
    * @param {string} textContent
    */
   _highlight(element, textContent) {
     var matches = this._highlightRegExp.exec(textContent);
     if (!matches || !matches.length)
       return;
     var range = new TextUtils.SourceRange(matches.index, matches[0].length);
     UI.highlightRangesWithStyleClass(element, [range], 'filter-highlight');
   }
 };