Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2701)

Unified Diff: content/browser/download/base_file.h

Issue 2890853002: Downloads: replace BrowserThread::FILE with task scheduler. (Closed)
Patch Set: Add a missing mock expectation. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/base_file.h
diff --git a/content/browser/download/base_file.h b/content/browser/download/base_file.h
index e630d778cfd88e68748c33574d124c7e260fcc7d..0ac963bdaaf289c678f1066024171fe938fcca35 100644
--- a/content/browser/download/base_file.h
+++ b/content/browser/download/base_file.h
@@ -16,6 +16,7 @@
#include "base/gtest_prod_util.h"
#include "base/logging.h"
#include "base/macros.h"
+#include "base/sequence_checker.h"
#include "base/time/time.h"
#include "content/common/content_export.h"
#include "content/public/browser/download_interrupt_reasons.h"
@@ -34,7 +35,7 @@ namespace content {
class CONTENT_EXPORT BaseFile {
public:
// May be constructed on any thread. All other routines (including
- // destruction) must occur on the FILE thread.
+ // destruction) must occur on the download task runner.
gab 2017/06/21 19:42:24 "on the same sequence"
Sigurður Ásgeirsson 2017/06/22 14:50:06 Done.
BaseFile(const net::NetLogWithSource& net_log);
~BaseFile();
@@ -253,6 +254,8 @@ class CONTENT_EXPORT BaseFile {
net::NetLogWithSource net_log_;
+ SEQUENCE_CHECKER(sequence_checker_);
+
DISALLOW_COPY_AND_ASSIGN(BaseFile);
};

Powered by Google App Engine
This is Rietveld 408576698