content/browser/download/download_task_runner.h - Issue 2890853002: Downloads: replace BrowserThread::FILE with task scheduler.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/download/download_task_runner.h

Issue 2890853002: Downloads: replace BrowserThread::FILE with task scheduler. (Closed)

Patch Set: Address Francios' comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/download/download_file_impl.cc ('K') | « content/browser/download/download_resource_handler.cc ('k') | content/browser/download/download_task_runner.cc » ('j') | content/browser/download/download_task_runner.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_TASK_RUNNER_H_

	6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_TASK_RUNNER_H_

	7

	8 #include "base/sequenced_task_runner.h"

	9 #include "content/common/content_export.h"

	10

	11 namespace content {

	12

	13 // Returns the task runner used to save files and do other blocking operations.

	14 CONTENT_EXPORT scoped_refptr<base::SequencedTaskRunner> GetDownloadTaskRunner();
	gab 2017/06/22 16:03:59 None of the callers require a refptr (some are eve None of the callers require a refptr (some are even forced to .get()), I'm going to update the LazyTaskRunner API to return a raw ptr by default instead to avoid unnecessary ref churn. In the meantime if you're so inclined this could return a SequencedTaskRunner* and the impl can .Get().get() with a TODO assigned to me + issue 730170. gab 2017/06/22 16:10:18 Nvm, looks like you do need the refptr in one plac Show quoted text On 2017/06/22 16:03:59, gab wrote: > None of the callers require a refptr (some are even forced to .get()), I'm going > to update the LazyTaskRunner API to return a raw ptr by default instead to avoid > unnecessary ref churn. In the meantime if you're so inclined this could return a > SequencedTaskRunner* and the impl can .Get().get() with a TODO assigned to me + > issue 730170. Nvm, looks like you do need the refptr in one place for CreateByteStream(). Sigurður Ásgeirsson 2017/06/22 18:47:28 Acknowledged. Show quoted text On 2017/06/22 16:10:18, gab (OOO Friday) wrote: > On 2017/06/22 16:03:59, gab wrote: > > None of the callers require a refptr (some are even forced to .get()), I'm > going > > to update the LazyTaskRunner API to return a raw ptr by default instead to > avoid > > unnecessary ref churn. In the meantime if you're so inclined this could return > a > > SequencedTaskRunner* and the impl can .Get().get() with a TODO assigned to me > + > > issue 730170. > > Nvm, looks like you do need the refptr in one place for CreateByteStream(). Acknowledged. Sigurður Ásgeirsson 2017/06/22 18:47:28 Acknowledged. Show quoted text On 2017/06/22 16:03:59, gab (OOO Friday) wrote: > None of the callers require a refptr (some are even forced to .get()), I'm going > to update the LazyTaskRunner API to return a raw ptr by default instead to avoid > unnecessary ref churn. In the meantime if you're so inclined this could return a > SequencedTaskRunner* and the impl can .Get().get() with a TODO assigned to me + > issue 730170. Acknowledged.
	15

	16 } // namespace content

	17

	18 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_TASK_RUNNER_H_

OLD	NEW