Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: components/translate/core/browser/translate_manager.cc

Issue 2890843003: Simplify TranslateRanker API. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_manager.cc
diff --git a/components/translate/core/browser/translate_manager.cc b/components/translate/core/browser/translate_manager.cc
index b714d3f99ccc7bf05d26a9e39069b80a84d4665e..06614e04420231a9779c17d234554669fa2d9bcb 100644
--- a/components/translate/core/browser/translate_manager.cc
+++ b/components/translate/core/browser/translate_manager.cc
@@ -220,8 +220,8 @@ void TranslateManager::InitiateTranslation(const std::string& page_lang) {
// Querying the ranker now, but not exiting immediately so that we may log
// other potential suppression reasons.
- bool should_offer_translation = translate_ranker_->ShouldOfferTranslation(
- *translate_prefs, language_code, target_lang, translate_event_.get());
+ bool should_offer_translation =
+ translate_ranker_->ShouldOfferTranslation(translate_event_.get());
// Nothing to do if either the language Chrome is in or the language of
// the page is not supported by the translation server.

Powered by Google App Engine
This is Rietveld 408576698