Policy implementation for encryptfs to ext4 migration strategy

components/arc/arc_util.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_ARC_UTIL_H_
 #define COMPONENTS_ARC_ARC_UTIL_H_
 
 // This file contains utility to see ARC functionality status controlled by
 // outside of ARC, e.g. CommandLine flag, attribute of global data/state,
 // users' preferences, and FeatureList.
 
 namespace aura {
 class Window;
 }  // namespace aura
 
 namespace base {
 class CommandLine;
 }  // namespace base
 
 namespace arc {
 
+constexpr char kAvailabilityOfficiallySupportedWithMigration[] =
+    "officially-supported-with-migration";

[hidehiko, 2017/05/25 12:41:56]

As commented in design doc, could you introduce another flag, rather than adding
new value to the support status.

I heard, what you need is whether the device was *originally* launched with
ecryptfs, regardless of the current file system.
So, it sounds independent from ARC's support status.

[igorcov, 2017/05/31 17:25:36]

Done.

+
+// The state of device policy DeviceEcryptfsMigrationStrategy, that points if
+// the migration to ext4 encryption is allowed. The ext4 encryption is required
+// for ARC(N+).
+// TODO(igorcov): Remove this after migration. crbug.com/725493
+enum ARC_AVAILABILITY_POLICY_STATUS {

[hidehiko, 2017/05/25 12:41:56]

nit: please use enum class.

style: Please use CamelCase. ArcAvailabilityPolicyStatus.

[igorcov, 2017/05/31 17:25:36]

Done.

+  // The policy value is unknown.
+  UNKNOWN = 0,
+  // ARC is disabled.
+  DISABLED = 1,
+  // ARC is available.
+  AVAILABLE = 2,
+};
+
+// This flag should be set the first time the policy fetch is done. It is to be
+// used if the device is set to need ext4 migration. In case its value is
+// UNKNOWN, the device is considered consumer owned.
+// TODO(igorcov): Remove this after migration. crbug.com/725493
+extern ARC_AVAILABILITY_POLICY_STATUS arc_availability_policy_status;

[hidehiko, 2017/05/25 12:41:56]

Please remove.
extern decl is not needed.

[igorcov, 2017/05/31 17:25:36]

Done.

+
 // Returns true if ARC is installed and the current device is officially
 // supported to run ARC.
 // Note that, to run ARC practically, it is necessary to meet more conditions,
 // e.g., ARC supports only on Primary User Profile. To see if ARC can actually
 // run for the profile etc., arc::ArcSessionManager::IsAllowedForProfile() is
 // the function for that purpose. Please see also its comment, too.
 // Also note that, ARC singleton classes (e.g. ArcSessionManager,
 // ArcServiceManager, ArcServiceLauncher) are instantiated regardless of this
 // check, so it is ok to access them directly.
 bool IsArcAvailable();
@@ skipping 31 matching lines @@
 bool IsArcKioskMode();
 
 // Checks if opt-in verification was disabled by switch in command line.
 // In most cases, it is disabled for testing purpose.
 bool IsArcOptInVerificationDisabled();
 
 // Returns true if the |window|'s aura::client::kAppType is ARC_APP. When
 // |window| is nullptr, returns false.
 bool IsArcAppWindow(aura::Window* window);
 
+// Setter for |arc_availability_policy_status|.
+void SetArcAvailabilityPolicyStatus(ARC_AVAILABILITY_POLICY_STATUS status);

[hidehiko, 2017/05/25 12:41:56]

Please explicitly document by-when this must be called.

+
+// Getter for |arc_availability_policy_status|.
+ARC_AVAILABILITY_POLICY_STATUS GetArcAvailabilityPolicyStatus();
+
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_ARC_UTIL_H_