Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 289083004: infobars: Componentize ConfirmInfoBarDelegate. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
droger, Peter Kasting
CC:
chromium-reviews, asanka, browser-components-watch_chromium.org, stuartmorgan+watch_chromium.org, dmazzoni+watch_chromium.org, markusheintz_, aandrey+blink_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, vsevik, benjhayden+dwatch_chromium.org, jam, marja+watch_chromium.org, benquan, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, dtseng+watch_chromium.org, fischman+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, pam+watch_chromium.org, Michael van Ouwerkerk, piman+watch_chromium.org, rouslan+autofillwatch_chromium.org, plundblad+watch_chromium.org, mcasas+watch_chromium.org, yurys, aboxhall+watch_chromium.org, native-client-reviews_googlegroups.com, Dane Wallinga, dyu1, estade+watch_chromium.org, wjia+watch_chromium.org, pfeldman, blundell, Ben Goodger (Google)
Visibility:
Public.

Description

infobars: Componentize ConfirmInfoBarDelegate. Changes: 1- Change it to use ui_strings.h 2- Use IDS_APP_OK and IDS_APP_CANCEL from ui_strings. 3- Move to components/infobars/core from chrome/browser/infobars (done with tools/git/move_source_file.py). BUG=373234 TEST=chrome still links and run fine. R=droger@chromium.org, pkasting@chromium.org TBR=ben # for trivial chrome/ changes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272036

Patch Set 1 #

Patch Set 2 : update grit_whitelist.txt #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -223 lines) Patch
M build/ios/grit_whitelist.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/accessibility/accessibility_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_interactive_uitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chrome_quota_permission_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_handlers/register_protocol_handler_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/download_request_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_url_tracker_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gpu/three_d_api_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/infobars/confirm_infobar_delegate.h View 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/browser/infobars/confirm_infobar_delegate.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M chrome/browser/infobars/insecure_content_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/simple_alert_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_mode_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_mode_navigation_observer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/media/media_stream_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/midi_permission_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/protected_media_identifier_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/notifications/notification_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/pepper_broker_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_infobar_delegates.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sessions/better_session_restore_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/confirm_infobar.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/confirm_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/auto_login_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/confirm_infobar_controller_unittest.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/keystone_infobar_delegate.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/collected_cookies_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/content_settings/media_setting_changed_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/extensions/extension_install_ui_default.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/hung_plugin_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/autolaunch_prompt_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/default_browser_prompt.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/google_api_keys_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/obsolete_system_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/session_crashed_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/confirm_infobar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/gpu/webgl_infobar_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/infobars.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M components/infobars/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + components/infobars/core/confirm_infobar_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/infobars/core/confirm_infobar_delegate.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
6 years, 7 months ago (2014-05-18 03:51:18 UTC) #1
tfarina
iOS seems to be the only platform not happy with this change. David, Roger, any ...
6 years, 7 months ago (2014-05-18 04:37:10 UTC) #2
droger
On 2014/05/18 04:37:10, tfarina wrote: > iOS seems to be the only platform not happy ...
6 years, 7 months ago (2014-05-18 06:07:37 UTC) #3
tfarina
On 2014/05/18 06:07:37, droger wrote: > On 2014/05/18 04:37:10, tfarina wrote: > > iOS seems ...
6 years, 7 months ago (2014-05-18 16:00:00 UTC) #4
droger
LGTM Note: ConfirmInfoBarDelegate should also be moved to the infobars:: namespace. It may be done ...
6 years, 7 months ago (2014-05-19 11:08:11 UTC) #5
Peter Kasting
RSLGTM
6 years, 7 months ago (2014-05-19 13:51:44 UTC) #6
tfarina
6 years, 7 months ago (2014-05-22 00:53:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r272036 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698