Cast: Add tests for clocks being slow/fast

Cast: Add tests for clocks being slow/fast

Fix the clock framework in end2end test to allow properly different clocks for sender and receiver.
Make the fake video codec behave more like our other codecs. (Instead of acting like 3-buffer mode)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271475

[Alpha Left Google, 2014-05-15 22:21:23]

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/end2end_...
File media/cast/test/end2end_unittest.cc (right):

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/end2end_...
media/cast/test/end2end_unittest.cc:1322: TEST_F(End2EndTest, WonkyClock2) {
How is this different from the test above? Please either have a comment or have
a more accurate test name.

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/fake_sin...
File media/cast/test/fake_single_thread_task_runner.cc (right):

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/fake_sin...
media/cast/test/fake_single_thread_task_runner.cc:63: for (int i = 0; i <
100000; i++) {
What is the constant used for? Please document.

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/fake_sin...
File media/cast/test/fake_single_thread_task_runner.h (right):

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/fake_sin...
media/cast/test/fake_single_thread_task_runner.h:28: void Sleep(base::TimeDelta
t);
This is a void method.

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/skewed_s...
File media/cast/test/skewed_single_thread_task_runner.h (right):

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/skewed_s...
media/cast/test/skewed_single_thread_task_runner.h:26: void SetSkew(double
skew);
Please document this method.

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/utility/...
File media/cast/test/utility/udp_proxy.h (right):

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/utility/...
media/cast/test/utility/udp_proxy.h:43: base::TickClock* clock_;
Please have a short comment like: "// Not owned.".

https://codereview.chromium.org/289083002/diff/20001/media/cast/video_sender/...
File media/cast/video_sender/fake_software_video_encoder.cc (right):

https://codereview.chromium.org/289083002/diff/20001/media/cast/video_sender/...
media/cast/video_sender/fake_software_video_encoder.cc:49: next_frame_is_key_ =
true;
nit: indentation was correct.

[hubbe, 2014-05-16 04:31:09]

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/end2end_...
File media/cast/test/end2end_unittest.cc (right):

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/end2end_...
media/cast/test/end2end_unittest.cc:1322: TEST_F(End2EndTest, WonkyClock2) {
On 2014/05/15 22:21:24, Alpha wrote:
> How is this different from the test above? Please either have a comment or
have
> a more accurate test name.

Done.

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/fake_sin...
File media/cast/test/fake_single_thread_task_runner.cc (right):

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/fake_sin...
media/cast/test/fake_single_thread_task_runner.cc:63: for (int i = 0; i <
100000; i++) {
On 2014/05/15 22:21:24, Alpha wrote:
> What is the constant used for? Please document.

Done.

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/fake_sin...
File media/cast/test/fake_single_thread_task_runner.h (right):

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/fake_sin...
media/cast/test/fake_single_thread_task_runner.h:28: void Sleep(base::TimeDelta
t);
On 2014/05/15 22:21:24, Alpha wrote:
> This is a void method.

Done.

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/skewed_s...
File media/cast/test/skewed_single_thread_task_runner.h (right):

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/skewed_s...
media/cast/test/skewed_single_thread_task_runner.h:26: void SetSkew(double
skew);
On 2014/05/15 22:21:24, Alpha wrote:
> Please document this method.

Done.

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/utility/...
File media/cast/test/utility/udp_proxy.h (right):

https://codereview.chromium.org/289083002/diff/20001/media/cast/test/utility/...
media/cast/test/utility/udp_proxy.h:43: base::TickClock* clock_;
On 2014/05/15 22:21:24, Alpha wrote:
> Please have a short comment like: "// Not owned.".

Done.

https://codereview.chromium.org/289083002/diff/20001/media/cast/video_sender/...
File media/cast/video_sender/fake_software_video_encoder.cc (right):

https://codereview.chromium.org/289083002/diff/20001/media/cast/video_sender/...
media/cast/video_sender/fake_software_video_encoder.cc:49: next_frame_is_key_ =
true;
On 2014/05/15 22:21:24, Alpha wrote:
> nit: indentation was correct.

Done.

[Alpha Left Google, 2014-05-16 18:20:51]

Looking good. Have one more question.

https://codereview.chromium.org/289083002/diff/60001/media/cast/test/fake_sin...
File media/cast/test/fake_single_thread_task_runner.cc (right):

https://codereview.chromium.org/289083002/diff/60001/media/cast/test/fake_sin...
media/cast/test/fake_single_thread_task_runner.cc:68: for (int i = 0; i <
100000; i++) {
Do we actually run into this problem? It is suspicious that tasks are posted
continuously.

[hubbe, 2014-05-16 18:24:55]

https://codereview.chromium.org/289083002/diff/60001/media/cast/test/fake_sin...
File media/cast/test/fake_single_thread_task_runner.cc (right):

https://codereview.chromium.org/289083002/diff/60001/media/cast/test/fake_sin...
media/cast/test/fake_single_thread_task_runner.cc:68: for (int i = 0; i <
100000; i++) {
On 2014/05/16 18:20:51, Alpha wrote:
> Do we actually run into this problem? It is suspicious that tasks are posted
> continuously. 

I did because of a bug in SkewedSingleThreadTaskRunner.

[Alpha Left Google, 2014-05-16 18:25:38]

Okay. LGTM.

[hubbe, 2014-05-16 18:26:36]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2014-05-16 18:27:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hubbe@chromium.org/289083002/60001

[commit-bot: I haz the power, 2014-05-17 09:34:25]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-17 09:38:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-17 09:38:14]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Alpha Left Google, 2014-05-18 23:55:30]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-05-18 23:55:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hubbe@chromium.org/289083002/60001

[commit-bot: I haz the power, 2014-05-19 00:39:46]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-19 00:42:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 00:42:14]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[hubbe, 2014-05-19 17:19:45]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2014-05-19 17:21:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hubbe@chromium.org/289083002/80001

[commit-bot: I haz the power, 2014-05-19 20:49:46]

Change committed as 271475