Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/android/BUILD.gn

Issue 2890813002: Separate WebView's locale paks from Chrome's locale paks (Closed)
Patch Set: remove unnecessary import Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 1a2527ee1387309919945f0f10c4abcce9802b67..16b6e0a6524c1903d6ce93afb8f58e2c3d9cd1fa 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -2,7 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("//android_webview/webview_repack_locales_list.gni")
import("//build/config/android/config.gni")
import("//build/config/android/rules.gni")
import("//build/util/process_version.gni")
@@ -600,9 +599,6 @@ android_assets("chrome_public_pak_assets") {
deps = [
":chrome_public_locale_pak_assets",
"//chrome:packed_resources",
- "//chrome/android/webapk/libs/runtime_library:runtime_library_assets",
- "//third_party/icu:icu_assets",
- "//v8:v8_external_startup_data_assets",
]
}
@@ -692,6 +688,7 @@ if (current_toolchain == default_toolchain) {
}
}
+ # This target does not output locale paks.
chrome_paks("monochrome_paks") {
output_dir = "$target_gen_dir/$target_name"
@@ -700,8 +697,7 @@ if (current_toolchain == default_toolchain) {
"//android_webview:generate_aw_resources",
]
- additional_locale_source_patterns = webview_repack_locales_source_patterns
- deps += webview_repack_locales_deps
+ exclude_locale_paks = true
if (enable_resource_whitelist_generation) {
repack_whitelist = monochrome_resource_whitelist
@@ -709,18 +705,18 @@ if (current_toolchain == default_toolchain) {
}
}
+ # This target explicitly includes locale paks.
agrieve 2017/05/17 19:29:44 nit: can you add "via deps" (took me a minute to f
F 2017/05/17 19:45:22 Done.
android_assets("monochrome_pak_assets") {
sources = [
"$target_gen_dir/monochrome_paks/chrome_100_percent.pak",
"$target_gen_dir/monochrome_paks/resources.pak",
]
- foreach(_locale, locales) {
- sources += [ "$target_gen_dir/monochrome_paks/locales/$_locale.pak" ]
- }
disable_compression = true
deps = [
+ ":chrome_public_locale_pak_assets",
":monochrome_paks",
+ "//android_webview:locale_pak_assets",
]
}
} # current_toolchain == host_toolchain

Powered by Google App Engine
This is Rietveld 408576698