Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2890803002: Perform type inference directly within kernel shadow infer() methods. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Perform type inference directly within kernel shadow infer() methods. Previously we deferred to methods in the TypeInferrerImpl object, on the theory that we would want to share this code with analyzer AST type inference. But we are no longer planning to do that, so the indirection is just cumbersome. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/58566c5488a56f5423ae9020a6179d212923253f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+469 lines, -750 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 24 chunks +369 lines, -55 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 8 chunks +94 lines, -695 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-17 14:39:15 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-17 14:50:36 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-17 15:38:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58566c5488a56f5423ae9020a6179d212923253f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698