Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1802)

Unified Diff: content/renderer/media/audio_ipc_factory.h

Issue 2890753003: Introduce AudioIPCFactory. (Closed)
Patch Set: Dale's comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/audio_device_factory.cc ('k') | content/renderer/media/audio_ipc_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/audio_ipc_factory.h
diff --git a/content/renderer/media/audio_ipc_factory.h b/content/renderer/media/audio_ipc_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..ae33fee508b88f502f050d94eaf3ec05de866b83
--- /dev/null
+++ b/content/renderer/media/audio_ipc_factory.h
@@ -0,0 +1,97 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_MEDIA_AUDIO_IPC_FACTORY_H_
+#define CONTENT_RENDERER_MEDIA_AUDIO_IPC_FACTORY_H_
+
+#include <memory>
+
+#include "base/containers/flat_map.h"
+#include "base/memory/ref_counted.h"
+#include "content/common/content_export.h"
+#include "content/common/media/renderer_audio_output_stream_factory.mojom.h"
+#include "content/renderer/media/audio_message_filter.h"
+
+namespace base {
+class SingleThreadTaskRunner;
+}
+
+namespace media {
+class AudioOutputIPC;
+}
+
+namespace service_manager {
+class InterfaceProvider;
+}
+
+namespace content {
+
+// This is a factory for AudioOutputIPC objects. It has two modes, using either
+// AudioMessageFilter or Mojo RendererAudioOutputStreamFactory objects. It is
+// threadsafe. This class is designed to be leaked at shutdown, as it posts
+// tasks to itself using base::Unretained and also hands out references to
+// itself in the AudioOutputIPCs it creates, but in the case where the owner is
+// sure that there are no outstanding references (such as in a unit test), the
+// class can be destructed.
+// TODO(maxmorin): Registering the factories for each frame will become
+// unnecessary when crbug.com/668275 is fixed. When that is done, this class can
+// be greatly simplified.
+class CONTENT_EXPORT AudioIPCFactory {
+ public:
+ AudioIPCFactory(scoped_refptr<AudioMessageFilter> audio_message_filter,
+ scoped_refptr<base::SingleThreadTaskRunner> io_task_runner);
+ ~AudioIPCFactory();
+
+ static AudioIPCFactory* get() { return instance_; }
+
+ const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner() const {
+ return io_task_runner_;
+ }
+
+ // Enables |this| to create MojoAudioOutputIPCs for the specified frame.
+ // Does nothing if not using mojo factories.
+ void MaybeRegisterRemoteFactory(
+ int frame_id,
+ service_manager::InterfaceProvider* interface_provider);
+
+ // Every call to the above method must be matched by a call to this one when
+ // the frame is destroyed. Does nothing if not using mojo factories.
+ void MaybeDeregisterRemoteFactory(int frame_id);
+
+ // The returned object may only be used on |io_task_runner()|.
+ std::unique_ptr<media::AudioOutputIPC> CreateAudioOutputIPC(
+ int frame_id) const;
+
+ private:
+ using StreamFactoryMap =
+ base::flat_map<int, mojom::RendererAudioOutputStreamFactoryPtr>;
+
+ mojom::RendererAudioOutputStreamFactory* GetRemoteFactory(int frame_id) const;
+
+ void RegisterRemoteFactoryOnIOThread(
+ int frame_id,
+ mojom::RendererAudioOutputStreamFactoryPtrInfo factory_ptr_info);
+
+ void MaybeDeregisterRemoteFactoryOnIOThread(int frame_id);
+
+ // Indicates whether mojo factories are used.
+ bool UsingMojoFactories() const;
+
+ // Maps frame id to the corresponding factory.
+ StreamFactoryMap factory_ptrs_;
+
+ // If this is non-null, it will be used rather than using mojo implementation.
+ const scoped_refptr<AudioMessageFilter> audio_message_filter_;
+
+ const scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
+
+ // Global instance, set in constructor and unset in destructor.
+ static AudioIPCFactory* instance_;
+
+ DISALLOW_COPY_AND_ASSIGN(AudioIPCFactory);
+};
+
+} // namespace content
+
+#endif // CONTENT_RENDERER_MEDIA_AUDIO_IPC_FACTORY_H_
« no previous file with comments | « content/renderer/media/audio_device_factory.cc ('k') | content/renderer/media/audio_ipc_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698