third_party/WebKit/Source/build/scripts/make_computed_style_base.py - Issue 2890743003: Do not use overridden getter names for internal getters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2890743003: Do not use overridden getter names for internal getters. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

index f961e6689207fd584eff1db2d36bde10d3152a1f..79ed0352cde62337e55f1807a49e75331c690d3f 100755

--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

@@ -148,7 +148,7 @@ class Field(object):

# TODO(nainar): Method name generation is inconsistent. Fix.

self.getter_method_name = getter_method_name

self.setter_method_name = setter_method_name

- self.internal_getter_method_name = method_name(join_name(getter_method_name, 'Internal'))

+ self.internal_getter_method_name = method_name(join_name(self.name, 'Internal'))

self.internal_mutable_method_name = method_name(join_name('Mutable', name_for_methods, 'Internal'))

self.internal_setter_method_name = method_name(join_name(setter_method_name, 'Internal'))

alancutter (OOO until 2018) 2017/05/19 01:55:23 Should the same apply to the setter?

self.initial_method_name = initial_method_name

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »