Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2890743003: Do not use overridden getter names for internal getters. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2016 The Chromium Authors. All rights reserved. 2 # Copyright 2016 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import math 6 import math
7 import sys 7 import sys
8 8
9 import json5_generator 9 import json5_generator
10 import template_expander 10 import template_expander
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 self.is_inherited = kwargs.pop('inherited') 141 self.is_inherited = kwargs.pop('inherited')
142 self.is_independent = kwargs.pop('independent') 142 self.is_independent = kwargs.pop('independent')
143 assert self.is_inherited or not self.is_independent, 'Only inherited fields can be independent' 143 assert self.is_inherited or not self.is_independent, 'Only inherited fields can be independent'
144 144
145 self.is_inherited_method_name = method_name(join_name(name_for_metho ds, 'is inherited')) 145 self.is_inherited_method_name = method_name(join_name(name_for_metho ds, 'is inherited'))
146 146
147 # Method names 147 # Method names
148 # TODO(nainar): Method name generation is inconsistent. Fix. 148 # TODO(nainar): Method name generation is inconsistent. Fix.
149 self.getter_method_name = getter_method_name 149 self.getter_method_name = getter_method_name
150 self.setter_method_name = setter_method_name 150 self.setter_method_name = setter_method_name
151 self.internal_getter_method_name = method_name(join_name(getter_method_n ame, 'Internal')) 151 self.internal_getter_method_name = method_name(join_name(self.name, 'Int ernal'))
152 self.internal_mutable_method_name = method_name(join_name('Mutable', nam e_for_methods, 'Internal')) 152 self.internal_mutable_method_name = method_name(join_name('Mutable', nam e_for_methods, 'Internal'))
153 self.internal_setter_method_name = method_name(join_name(setter_method_n ame, 'Internal')) 153 self.internal_setter_method_name = method_name(join_name(setter_method_n ame, 'Internal'))
alancutter (OOO until 2018) 2017/05/19 01:55:23 Should the same apply to the setter?
154 self.initial_method_name = initial_method_name 154 self.initial_method_name = initial_method_name
155 self.resetter_method_name = method_name(join_name('Reset', name_for_meth ods)) 155 self.resetter_method_name = method_name(join_name('Reset', name_for_meth ods))
156 if self.group_name: 156 if self.group_name:
157 self.getter_expression = self.group_member_name + '->' + class_membe r_name(self.name) 157 self.getter_expression = self.group_member_name + '->' + class_membe r_name(self.name)
158 else: 158 else:
159 self.getter_expression = class_member_name(self.name) 159 self.getter_expression = class_member_name(self.name)
160 160
161 # If the size of the field is not None, it means it is a bit field 161 # If the size of the field is not None, it means it is a bit field
162 self.is_bit_field = self.size is not None 162 self.is_bit_field = self.size is not None
163 163
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 442
443 @template_expander.use_jinja('ComputedStyleBaseConstants.h.tmpl') 443 @template_expander.use_jinja('ComputedStyleBaseConstants.h.tmpl')
444 def generate_base_computed_style_constants(self): 444 def generate_base_computed_style_constants(self):
445 return { 445 return {
446 'properties': self._properties, 446 'properties': self._properties,
447 'enums': self._generated_enums, 447 'enums': self._generated_enums,
448 } 448 }
449 449
450 if __name__ == '__main__': 450 if __name__ == '__main__':
451 json5_generator.Maker(ComputedStyleBaseWriter).main() 451 json5_generator.Maker(ComputedStyleBaseWriter).main()
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698