Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2890743002: [ios] Fix compilation in Release with dcheck_always_on=true. (Closed)

Created:
3 years, 7 months ago by sdefresne
Modified:
3 years, 7 months ago
Reviewers:
gab
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fix compilation in Release with dcheck_always_on=true. BUG=722827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ios/web/web_state/ui/wk_web_view_configuration_provider.mm View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
sdefresne
Please take a look and send to CQ if LGTY. That way you won't have ...
3 years, 7 months ago (2017-05-17 08:11:16 UTC) #4
gab
3 years, 7 months ago (2017-05-17 20:12:49 UTC) #7
Message was sent while issue was closed. 
On 2017/05/17 08:11:16, sdefresne OOO till 22-05-2017 wrote:
> Please take a look and send to CQ if LGTY. That way you won't have to fix this
> again when you re-enable dcheck_always_on=true by default for non official
> builds.

Oops missed that before sending equivalent CL this morning :), lgtm but will
close..!

Powered by Google App Engine
This is Rietveld 408576698