Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Issue 289073008: Add TriggerOnUninstalled to ExtensionRegistry (Closed)

Created:
6 years, 7 months ago by limasdf
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add TriggerOnUninstalled to ExtensionRegistry. And change ExtensionToolbarModel to use it instead of NOTIFICATION_EXTENSION_UNINSTALLED. R=kalman@chromium.org BUG=354459 TEST=unit_test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272649

Patch Set 1 : #

Total comments: 2

Patch Set 2 : address review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -40 lines) Patch
M chrome/browser/extensions/extension_service.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 4 chunks +27 lines, -39 lines 0 comments Download
M extensions/browser/extension_registry.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/extension_registry.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/browser/extension_registry_observer.h View 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/extension_registry_unittest.cc View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
limasdf
please take a look, after submit. I'll rename NOTIFICATION_EXTENSION_UNINSTALLED to ~_DEPRECATED.
6 years, 7 months ago (2014-05-23 20:17:03 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/289073008/diff/80001/chrome/browser/extensions/extension_toolbar_model.cc File chrome/browser/extensions/extension_toolbar_model.cc (right): https://codereview.chromium.org/289073008/diff/80001/chrome/browser/extensions/extension_toolbar_model.cc#newcode197 chrome/browser/extensions/extension_toolbar_model.cc:197: UninstalledExtension(extension); given the only caller of UninstalledExtension is ...
6 years, 7 months ago (2014-05-23 20:24:05 UTC) #2
limasdf
Thanks. I'll commit then... https://codereview.chromium.org/289073008/diff/80001/chrome/browser/extensions/extension_toolbar_model.cc File chrome/browser/extensions/extension_toolbar_model.cc (right): https://codereview.chromium.org/289073008/diff/80001/chrome/browser/extensions/extension_toolbar_model.cc#newcode197 chrome/browser/extensions/extension_toolbar_model.cc:197: UninstalledExtension(extension); On 2014/05/23 20:24:05, kalman ...
6 years, 7 months ago (2014-05-23 20:47:21 UTC) #3
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-05-23 20:47:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/289073008/100001
6 years, 7 months ago (2014-05-23 20:49:03 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 00:11:55 UTC) #6
Message was sent while issue was closed.
Change committed as 272649

Powered by Google App Engine
This is Rietveld 408576698