Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 289073005: [webcrypto] Hook up parameter normalization for RSA-OAEP. (Closed)

Created:
6 years, 7 months ago by eroman
Modified:
6 years, 7 months ago
Reviewers:
jww
CC:
blink-reviews
Visibility:
Public.

Description

[webcrypto] Hook up parameter normalization for RSA-OAEP. BUG=245025, 372917 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174523

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Patch Set 3 : rebase #

Messages

Total messages: 7 (0 generated)
eroman
6 years, 7 months ago (2014-05-16 02:32:50 UTC) #1
adamk
Maybe jww can review while abarth is out?
6 years, 7 months ago (2014-05-20 07:48:15 UTC) #2
jww
lgtm, modulo nits. https://codereview.chromium.org/289073005/diff/1/LayoutTests/crypto/rsa-oaep-parseAlgorithmFailures.html File LayoutTests/crypto/rsa-oaep-parseAlgorithmFailures.html (right): https://codereview.chromium.org/289073005/diff/1/LayoutTests/crypto/rsa-oaep-parseAlgorithmFailures.html#newcode1 LayoutTests/crypto/rsa-oaep-parseAlgorithmFailures.html:1: <!DOCTYPE html> nit: Name of this ...
6 years, 7 months ago (2014-05-21 15:04:21 UTC) #3
eroman
Thanks for the review! https://codereview.chromium.org/289073005/diff/1/LayoutTests/crypto/rsa-oaep-parseAlgorithmFailures.html File LayoutTests/crypto/rsa-oaep-parseAlgorithmFailures.html (right): https://codereview.chromium.org/289073005/diff/1/LayoutTests/crypto/rsa-oaep-parseAlgorithmFailures.html#newcode1 LayoutTests/crypto/rsa-oaep-parseAlgorithmFailures.html:1: <!DOCTYPE html> On 2014/05/21 15:04:22, ...
6 years, 7 months ago (2014-05-21 17:46:33 UTC) #4
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-21 19:08:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/289073005/60001
6 years, 7 months ago (2014-05-21 19:11:06 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 05:23:46 UTC) #7
Message was sent while issue was closed.
Change committed as 174523

Powered by Google App Engine
This is Rietveld 408576698