Issue 289073003: Bump up average_time_between_callback_ms for audio unittest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 289073003: Bump up average_time_between_callback_ms for audio unittest (Closed)

Created:
6 years, 7 months ago by Dirk Pranke

Modified:
6 years, 7 months ago

Reviewers:
tommi (sloooow) - chröme, DaleCurtis, henrika (OOO until Aug 14)

CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Bump up average_time_between_callback_ms for audio unittest AudioAndroidOutputTest.StartOutputStreamCallbacksNonDefaultParameters checks to make sure the callbacks are not exceeding 1.3x the average callback time, but this appears to be a bit too aggressive on some android devices, and bots are failing the test. Increasing the threshold to 1.35x for now until some code owner can look at this and see if there is a better fix. TBR=dalecurtis@chromium.org, tommi@chromium.org, henrika@chromium.org BUG=373945 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270836

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	media/audio/android/audio_android_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Committed patchset #1 manually as r270836 (presubmit successful).

6 years, 7 months ago (2014-05-15 22:46:45 UTC) #3

Message was sent while issue was closed.

LGTM. Thanks for doing this.

Expand Messages | Collapse Messages