SafeBrowsing: allow WebView to customize the Help Center URL

components/security_interstitials/core/base_safe_browsing_error_ui.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SECURITY_INTERSTITIALS_CORE_BASE_SAFE_BROWSING_ERROR_UI_H_
 #define COMPONENTS_SECURITY_INTERSTITIALS_CORE_BASE_SAFE_BROWSING_ERROR_UI_H_
 
 #include "base/macros.h"
 #include "base/time/time.h"
 #include "base/values.h"
@@ skipping 14 matching lines @@
     SB_REASON_PHISHING,
   };
 
   struct SBErrorDisplayOptions {
     SBErrorDisplayOptions(bool is_main_frame_load_blocked,
                           bool is_extended_reporting_opt_in_allowed,
                           bool is_off_the_record,
                           bool is_extended_reporting_enabled,
                           bool is_scout_reporting_enabled,
                           bool is_proceed_anyway_disabled,
-                          bool is_resource_cancellable)
+                          bool is_resource_cancellable,
+                          const char* plink)

[Jialiu Lin, 2017/05/17 15:47:46]

nit: prefer const std::string&  over const char*

[Nate Fischer, 2017/05/17 22:34:43]

Done

         : is_main_frame_load_blocked(is_main_frame_load_blocked),
           is_extended_reporting_opt_in_allowed(
               is_extended_reporting_opt_in_allowed),
           is_off_the_record(is_off_the_record),
           is_extended_reporting_enabled(is_extended_reporting_enabled),
           is_scout_reporting_enabled(is_scout_reporting_enabled),
           is_proceed_anyway_disabled(is_proceed_anyway_disabled),
-          is_resource_cancellable(is_resource_cancellable) {}
+          is_resource_cancellable(is_resource_cancellable),
+          plink(plink) {}
 
     // Indicates if this SB interstitial is blocking main frame load.
     bool is_main_frame_load_blocked;
 
     // Indicates if user is allowed to opt-in extended reporting preference.
     bool is_extended_reporting_opt_in_allowed;
 
     // Indicates if user is in incognito mode.
     bool is_off_the_record;
 
     // Indicates if user opted in for SB extended reporting.
     bool is_extended_reporting_enabled;
 
     // Indicates if user opted in for Scout extended reporting.
     bool is_scout_reporting_enabled;
 
     // Indicates if kSafeBrowsingProceedAnywayDisabled preference is set.
     bool is_proceed_anyway_disabled;
 
     // Indicates if "back to safety" should cancel the pending navigation or
     // navigate back after it's committed.
     bool is_resource_cancellable;
+
+    // The p= query parameter used when visiting the Help Center. If this is
+    // nullptr, then a default value will be used for the SafeBrowsing article.
+    const char* plink;

[Jialiu Lin, 2017/05/17 15:47:46]

nit: plink is a very general name, unless you want to reuse it for other
purpose, how about just called help_center_article_link?  And prefer const
std::string over char*.

[Nate Fischer, 2017/05/17 22:34:43]

Done

   };
 
   BaseSafeBrowsingErrorUI(
       const GURL& request_url,
       const GURL& main_frame_url,
       BaseSafeBrowsingErrorUI::SBInterstitialReason reason,
       const BaseSafeBrowsingErrorUI::SBErrorDisplayOptions& display_options,
       const std::string& app_locale,
       const base::Time& time_triggered,
       ControllerClient* controller);
@@ skipping 22 matching lines @@
   }
 
   bool is_proceed_anyway_disabled() const {
     return display_options_.is_proceed_anyway_disabled;
   }
 
   bool is_resource_cancellable() const {
     return display_options_.is_resource_cancellable;
   }
 
+  const char* get_plink() const { return display_options_.plink; }
+
   // Checks if we should even show the extended reporting option. We don't show
   // it in incognito mode or if kSafeBrowsingExtendedReportingOptInAllowed
   // preference is disabled.
   bool CanShowExtendedReportingOption() {
     return !is_off_the_record() && is_extended_reporting_opt_in_allowed();
   }
 
   SBInterstitialReason interstitial_reason() const {
     return interstitial_reason_;
   }
@@ skipping 18 matching lines @@
   const base::Time time_triggered_;
 
   ControllerClient* controller_;
 
   DISALLOW_COPY_AND_ASSIGN(BaseSafeBrowsingErrorUI);
 };
 
 }  // security_interstitials
 
 #endif  // COMPONENTS_SECURITY_INTERSTITIALS_CORE_BASE_SAFE_BROWSING_ERROR_UI_H_