Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2890633002: Refactor common code between method and constructor inference. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor common code between method and constructor inference. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/798890256f4603639d1dcc09fd99e97061afc0c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -127 lines) Patch
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 3 chunks +98 lines, -127 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-16 20:59:12 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-16 21:00:55 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-16 21:09:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
798890256f4603639d1dcc09fd99e97061afc0c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698