Mojo: Remove SetClient from generated interfaces

Mojo: Remove SetClient from generated interfaces

Instead, we have InterfacePtr::set_client(..) and InterfaceImpl getting a
client set on it internally. This simplifies InterfaceImpl quite a bit.

BUG=374436
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272441

[DaveMoore, 2014-05-20 20:20:00]

LGTM

Nit: We should be clear that you can call set_client() before or after the Bind
/ Connect calls.

Nit: Would it be worth creating versions of Bind / Connect that take the client
as an arg?

[darin (slow to review), 2014-05-22 21:01:47]

On 2014/05/20 20:20:00, DaveMoore wrote:
> LGTM
> 
> Nit: We should be clear that you can call set_client() before or after the
Bind
> / Connect calls.

Hmm, it doesn't work that way. InterfacePtr<> only permits set_client() after
the InterfacePtr<> has been bound. I have a comment saying that above
set_client().


> Nit: Would it be worth creating versions of Bind / Connect that take the
client
> as an arg?

I considered it, but the InterfacePtr<> will mostly be bound by separate
code--by
the bindings system--and you will get an InterfacePtr<> and then want to set a 
client on it. The places where you see both the binding and set_client call
together
are cases where you start out with a MessagePipeHandle. If we are burying the
pipes,
then that case should be rare.

[darin (slow to review), 2014-05-22 21:02:13]

The CQ bit was checked by darin@chromium.org

[commit-bot: I haz the power, 2014-05-22 21:04:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/darin@chromium.org/289063015/60001

[commit-bot: I haz the power, 2014-05-23 00:05:47]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-23 07:57:22]

Change committed as 272441