Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 289063012: [Hotword] Add error message display back in. Add error messages for NaCl. Add metrics for errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: android compile error Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index 5bbd7f092ee73116bba45cb5cbd71dd6fc6fed03..59fe9ebd4ae955efac37bb08999569084ed71ec5 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -178,6 +178,9 @@ cr.define('options', function() {
};
chrome.send('requestHotwordAvailable');
+ var hotwordIndicator = $('hotword-search-setting-indicator');
+ HotwordSearchSettingIndicator.decorate(hotwordIndicator);
+ hotwordIndicator.disabledOnErrorSection = $('hotword-search-enable');
if ($('set-wallpaper')) {
$('set-wallpaper').onclick = function(event) {
@@ -990,10 +993,14 @@ cr.define('options', function() {
/**
* Activates the Hotword section from the System settings page.
+ * @param {string} opt_error The error message to display.
+ * @param {string} opt_help_link The link to a troubleshooting page.
* @private
*/
- showHotwordSection_: function(opt_error) {
+ showHotwordSection_: function(opt_error, opt_help_link) {
$('hotword-search').hidden = false;
+ $('hotword-search-setting-indicator').errorText = opt_error;
+ $('hotword-search-setting-indicator').helpLink = opt_help_link;
},
/**

Powered by Google App Engine
This is Rietveld 408576698