Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 2890613002: Remove unneeded code in NavigatorImpl::OnBeginNavigation.
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index c677f372f5767093b64cb134621ef84a3f4c3e10..893d12a2ff89e41a8a191fa33ac38f72bec0bdd3 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -979,17 +979,6 @@ void NavigatorImpl::OnBeginNavigation(
NavigationRequest* ongoing_navigation_request =
frame_tree_node->navigation_request();
- // Client redirects during the initial history navigation of a child frame
- // should take precedence over the history navigation (despite being renderer-
- // initiated). See https://crbug.com/348447 and https://crbug.com/691168.
- if (ongoing_navigation_request &&
- ongoing_navigation_request->request_params()
- .is_history_navigation_in_new_child) {
- // Preemptively clear this local pointer before deleting the request.
- ongoing_navigation_request = nullptr;
- frame_tree_node->ResetNavigationRequest(false, true);
- }
-
// The renderer-initiated navigation request is ignored iff a) there is an
// ongoing request b) which is browser or user-initiated and c) the renderer
// request is not user-initiated.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698