Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2890603002:
input: Delay the dispatch of synthesized input event. (Closed)
Descriptioninput: Delay the dispatch of synthesized input event.
Instead of dispatching synthesized input events at the same time as
begin-frame, delay the dispatch of the events by a few milliseconds.
This is expected to better reflect real use scenario.
BUG=722921
Patch Set 1 #Patch Set 2 : . #
Total comments: 2
Patch Set 3 : tot merge #Messages
Total messages: 18 (13 generated)
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
sadrul@chromium.org changed reviewers: + dtapuska@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2890603002/diff/20001/content/browser/rendere... File content/browser/renderer_host/input/synthetic_gesture_controller.cc (right): https://codereview.chromium.org/2890603002/diff/20001/content/browser/rendere... content/browser/renderer_host/input/synthetic_gesture_controller.cc:44: base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( I don't think this is quite right. Didn't we want a repeating timer? that is sync'd on the first main frame signal?
https://codereview.chromium.org/2890603002/diff/20001/content/browser/rendere... File content/browser/renderer_host/input/synthetic_gesture_controller.cc (right): https://codereview.chromium.org/2890603002/diff/20001/content/browser/rendere... content/browser/renderer_host/input/synthetic_gesture_controller.cc:44: base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( On 2017/05/17 16:30:45, dtapuska wrote: > I don't think this is quite right. Didn't we want a repeating timer? that is > sync'd on the first main frame signal? Yep, that's where we want to go. I am trying to take smaller steps here (1) dispatch at (begin-frame + offset) (2) dispatch at regular intervals after the first (begin-frame + offset), still one event per begin-frame (3) dispatch more than one events per begin-frame. This is step 1. I am happy to go to step 2 at the same time if you don't think taking step 1 separately is necessary (although I should probably leave a TODO explaining the next steps).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Closing this. We went directly to https://codereview.chromium.org/2886263002 |
