third_party/WebKit/LayoutTests/compositing/overflow/ancestor-overflow-layer-of-sticky-child-of-compositing-container.html - Issue 2890583002: Fix incorrect use of coords conversion for sticky elements

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/overflow/ancestor-overflow-layer-of-sticky-child-of-compositing-container.html

Issue 2890583002: Fix incorrect use of coords conversion for sticky elements (Closed)

Patch Set: Add comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/compositing/overflow/ancestor-overflow-layer-of-sticky-child-of-compositing-container-expected.html » ('j') | third_party/WebKit/LayoutTests/compositing/overflow/ancestor-overflow-layer-of-sticky-child-of-compositing-container-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 .fixed {

	4 position: fixed;
	flackr 2017/05/19 18:28:31 I think will-change: transform will work just as w I think will-change: transform will work just as well, and has fewer side effects. yigu 2017/05/23 19:16:40 I think position:fixed is necessary to reproduce t Show quoted text On 2017/05/19 18:28:31, flackr wrote: > I think will-change: transform will work just as well, and has fewer side > effects. I think position:fixed is necessary to reproduce this bug (although "will-change:transform" creates the same layer structure). For sticky elements, the offset from compositing_container to ancestor_overflow_layer is computed by source_to_parent iff it has ScrollParent and fix positioned container. flackr 2017/05/23 19:19:59 Doesn't this imply that the test would still be br Show quoted text On 2017/05/23 19:16:40, yigu wrote: > On 2017/05/19 18:28:31, flackr wrote: > > I think will-change: transform will work just as well, and has fewer side > > effects. > > I think position:fixed is necessary to reproduce this bug (although > "will-change:transform" creates the same layer structure). For sticky elements, > the offset from compositing_container to ancestor_overflow_layer is computed by > source_to_parent iff it has ScrollParent and fix positioned container. Doesn't this imply that the test would still be broken for will-change: transform if the source_to_parent calculation isn't done?
	5 }

	6

	7 .sticky {

	8 position: sticky;

	9 top: 0;

	10 }

	11

	12 .composited {

	13 /* Force compositing without creating a stacking context */

	14 backface-visibility: hidden;

	15 }

	16

	17 .spacer {

	18 height: 2000px;

	19 }

	20

	21 .container {

	22 width: 500px;

	23 height: 500px;

	24 overflow: scroll;

	25 }

	26 </style>

	27

	28 <div class="composited fixed">

	29 Ref text.

	30 <div class="composited container">

	31 <div class="sticky">

	32 This line should line up with the text above.

	33 </div>

	34 <div class="spacer"></div>

	35 </div>

	36 </div>

	37

OLD	NEW