VR: Update UiSceneManager with audio/video capturing flags

chrome/browser/android/vr_shell/vr_shell.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/vr_shell.h"
 
 #include <android/native_window_jni.h>
 
 #include <string>
 #include <utility>
@@ skipping 533 matching lines @@
       base::Bind(&VrShell::PollMediaAccessFlag, base::Unretained(this)));
   main_thread_task_runner_->PostDelayedTask(
       FROM_HERE, poll_capturing_media_task_.callback(),
       poll_media_access_interval_);
 
   scoped_refptr<MediaStreamCaptureIndicator> indicator =
       MediaCaptureDevicesDispatcher::GetInstance()
           ->GetMediaStreamCaptureIndicator();
   bool is_capturing_audio = indicator->IsCapturingAudio(web_contents_);
   if (is_capturing_audio != is_capturing_audio_)
-    PostToGlThreadWhenReady(base::Bind(&VrShellGl::SetAudioCapturingWarning,
-                                       gl_thread_->GetVrShellGl(),
-                                       is_capturing_audio));
+    gl_thread_->task_runner()->PostTask(

[cjgrant, 2017/05/16 19:09:27]

These calls should go through the ui_ interface.  See other similar calls.  We
should only be using this direct approach for things that are directly dependent
on the GL implementation.  Note that you'll have to add methods to the interface
as well.

The point of all this is to keep this module cleaner, hide the cross-thread
implementation, and make pieces more testable.

[asimjour1, 2017/05/16 20:13:55]

Done.

+        FROM_HERE,
+        base::Bind(&UiSceneManager::SetAudioCapturingIndicator,
+                   gl_thread_->GetSceneManager(), is_capturing_audio));
+
   is_capturing_audio_ = is_capturing_audio;
 
   bool is_capturing_video = indicator->IsCapturingVideo(web_contents_);
   if (is_capturing_video != is_capturing_video_)
-    PostToGlThreadWhenReady(base::Bind(&VrShellGl::SetVideoCapturingWarning,
-                                       gl_thread_->GetVrShellGl(),
-                                       is_capturing_video));
+    gl_thread_->task_runner()->PostTask(
+        FROM_HERE,
+        base::Bind(&UiSceneManager::SetVideoCapturingIndicator,
+                   gl_thread_->GetSceneManager(), is_capturing_video));
   is_capturing_video_ = is_capturing_video;
 
   bool is_capturing_screen = indicator->IsBeingMirrored(web_contents_);
   if (is_capturing_screen != is_capturing_screen_)
-    PostToGlThreadWhenReady(base::Bind(&VrShellGl::SetScreenCapturingWarning,
-                                       gl_thread_->GetVrShellGl(),
-                                       is_capturing_screen));
+    gl_thread_->task_runner()->PostTask(
+        FROM_HERE,
+        base::Bind(&UiSceneManager::SetScreenCapturingIndicator,
+                   gl_thread_->GetSceneManager(), is_capturing_screen));
+
   is_capturing_screen_ = is_capturing_screen;
 }
 
 void VrShell::SetContentCssSize(float width, float height, float dpr) {
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_VrShellImpl_setContentCssSize(env, j_vr_shell_.obj(), width, height,
                                      dpr);
 }
 
 void VrShell::ProcessContentGesture(
@@ skipping 40 matching lines @@
            jlong gvr_api,
            jboolean reprojected_rendering) {
   return reinterpret_cast<intptr_t>(new VrShell(
       env, obj, reinterpret_cast<ui::WindowAndroid*>(window_android),
       for_web_vr, in_cct,
       VrShellDelegate::GetNativeVrShellDelegate(env, delegate),
       reinterpret_cast<gvr_context*>(gvr_api), reprojected_rendering));
 }
 
 }  // namespace vr_shell