chrome/browser/android/vr_shell/ui_scene_manager.h - Issue 2890563003: VR: Update UiSceneManager with audio/video capturing flags

Side by Side Diff: chrome/browser/android/vr_shell/ui_scene_manager.h

Issue 2890563003: VR: Update UiSceneManager with audio/video capturing flags (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_ANDROID_VR_SHELL_UI_SCENE_MANAGER_H_	5 #ifndef CHROME_BROWSER_ANDROID_VR_SHELL_UI_SCENE_MANAGER_H_

6 #define CHROME_BROWSER_ANDROID_VR_SHELL_UI_SCENE_MANAGER_H_	6 #define CHROME_BROWSER_ANDROID_VR_SHELL_UI_SCENE_MANAGER_H_

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "base/memory/weak_ptr.h"	9 #include "base/memory/weak_ptr.h"

10 #include "base/timer/timer.h"	10 #include "base/timer/timer.h"

(...skipping 25 matching lines...) Expand all Loading...
36 void SetWebVrSecureOrigin(bool secure);	36 void SetWebVrSecureOrigin(bool secure);

37 void SetWebVrMode(bool web_vr);	37 void SetWebVrMode(bool web_vr);

38 // These methods are currently stubbed.	38 // These methods are currently stubbed.

39 void SetSecurityLevel(int level);	39 void SetSecurityLevel(int level);

40 void SetLoading(bool loading);	40 void SetLoading(bool loading);

41 void SetLoadProgress(float progress);	41 void SetLoadProgress(float progress);

42 void SetHistoryButtonsEnabled(bool can_go_back, bool can_go_forward);	42 void SetHistoryButtonsEnabled(bool can_go_back, bool can_go_forward);

43	43

44 void OnAppButtonClicked();	44 void OnAppButtonClicked();

45 void OnAppButtonGesturePerformed(UiInterface::Direction direction);	45 void OnAppButtonGesturePerformed(UiInterface::Direction direction);

	46 void SetAudioCapturingIndicator(bool is_capturing);
	cjgrant 2017/05/16 19:09:27 These could go up with the other setters. We migh These could go up with the other setters. We might as well remove the "currently stubbed" as it's no longer true, and just alphabetize all the Set methods. asimjour1 2017/05/16 20:13:55 Moved them next to the other setters, but I rather Show quoted text On 2017/05/16 19:09:27, cjgrant wrote: > These could go up with the other setters. We might as well remove the > "currently stubbed" as it's no longer true, and just alphabetize all the Set > methods. Moved them next to the other setters, but I rather to keep them together instead of sorting.
	47 void SetVideoCapturingIndicator(bool is_capturing);

	48 void SetScreenCapturingIndicator(bool is_capturing);
	cjgrant 2017/05/16 19:09:27 Up to you, but based on method name, argument "boo Up to you, but based on method name, argument "bool enabled" seems plenty clear and shorter. :) asimjour1 2017/05/16 20:13:55 Done. Show quoted text On 2017/05/16 19:09:27, cjgrant wrote: > Up to you, but based on method name, argument "bool enabled" seems plenty clear > and shorter. :) Done.
46	49

47 private:	50 private:

48 void CreateSecurityWarnings();	51 void CreateSecurityWarnings();

49 void CreateSystemIndicators();	52 void CreateSystemIndicators();

50 void CreateContentQuad();	53 void CreateContentQuad();

51 void CreateBackground();	54 void CreateBackground();

52 void CreateUrlBar();	55 void CreateUrlBar();

53 void CreateCloseButton();	56 void CreateCloseButton();

54	57

55 void ConfigureScene();	58 void ConfigureScene();

(...skipping 28 matching lines...) Expand all Loading...
84 base::OneShotTimer security_warning_timer_;	87 base::OneShotTimer security_warning_timer_;

85	88

86 base::WeakPtrFactory<UiSceneManager> weak_ptr_factory_;	89 base::WeakPtrFactory<UiSceneManager> weak_ptr_factory_;

87	90

88 DISALLOW_COPY_AND_ASSIGN(UiSceneManager);	91 DISALLOW_COPY_AND_ASSIGN(UiSceneManager);

89 };	92 };

90	93

91 } // namespace vr_shell	94 } // namespace vr_shell

92	95

93 #endif // CHROME_BROWSER_ANDROID_VR_SHELL_UI_SCENE_MANAGER_H_	96 #endif // CHROME_BROWSER_ANDROID_VR_SHELL_UI_SCENE_MANAGER_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/ui_scene_manager.cc » ('j') | chrome/browser/android/vr_shell/ui_scene_manager.cc » ('J')