Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Unified Diff: test/inspector/console/destroy-context-during-log.js

Issue 2890463004: [inspector] Refactor inspector test (Closed)
Patch Set: better crash fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/inspector/debugger/destory-in-break-program.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/inspector/console/destroy-context-during-log.js
diff --git a/test/inspector/console/destroy-context-during-log.js b/test/inspector/console/destroy-context-during-log.js
index 274165ca0ce14ff852fd8ae3d08a87ff95668a92..0d3d13b69777692d17e6d9636dcdbdabbe2af35c 100644
--- a/test/inspector/console/destroy-context-during-log.js
+++ b/test/inspector/console/destroy-context-during-log.js
@@ -10,11 +10,11 @@ const expression = `
delete Object.prototype.RemoteObject;
this.RemoteObject = v;
- inspector.detachInspector();
+ inspector.fireContextDestroyed();
setTimeout(function() {
// Attach the inspector again for the sake of establishing a
// communication channel with the frontend test runner.
- inspector.attachInspector();
+ inspector.fireContextCreated();
console.log("End of test");
}, 0);
},
@@ -23,8 +23,8 @@ const expression = `
// Before the whole script runs, the inspector is already attached.
// Re-attach the inspector and trigger the console API to make sure that the
// injected inspector script runs again (and triggers the above setter).
- inspector.detachInspector();
- inspector.attachInspector();
+ inspector.fireContextDestroyed();
+ inspector.fireContextCreated();
console.log("First inspector activity after attaching inspector");
console.log("End of test");
`;
« no previous file with comments | « no previous file | test/inspector/debugger/destory-in-break-program.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698