Implement MusContextFactory::SharedMainThreadContextProvider()

ui/aura/mus/mus_context_factory.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/mus/mus_context_factory.h"
 
 #include "base/command_line.h"
 #include "base/memory/ptr_util.h"
 #include "cc/base/switches.h"
 #include "services/ui/public/cpp/gpu/gpu.h"
@@ skipping 44 matching lines @@
 
 void MusContextFactory::CreateCompositorFrameSink(
     base::WeakPtr<ui::Compositor> compositor) {
   gpu_->EstablishGpuChannel(
       base::Bind(&MusContextFactory::OnEstablishedGpuChannel,
                  weak_ptr_factory_.GetWeakPtr(), compositor));
 }
 
 scoped_refptr<cc::ContextProvider>
 MusContextFactory::SharedMainThreadContextProvider() {
-  // NOTIMPLEMENTED();
-  return nullptr;
+  if (!shared_main_thread_context_provider_) {
+    // In this point, the gpu channel should be already established in gpu_,
+    // the gpu_->EstablishGpuChannelSync() just returns the gpu channel
+    // immediately.

[sadrul, 2017/05/16 19:34:27]

Can you verify that here? i.e. have a bool flag that gets turned on in
::OnEstablishedGpuChannel() above, and either DCHECK() on the flag here, or
return nullptr if the flag is not set.

[Peng, 2017/05/16 19:52:08]

I think we shouldn't DCHECK it, because ui::ContextFactory is defined in this
way. In most case, the GpuChannel has been established, if not we have to
establish the channel synchronously. Also see [1], we also do the sync IPC in
GpuProcessTransportFactory::SharedMainThreadContextProvider().

[1]
https://cs.chromium.org/chromium/src/content/browser/compositor/gpu_process_t...

[sadrul, 2017/05/16 19:53:27]

If we cannot depend on this, can you remove/update the comment?

[Peng, 2017/05/16 19:56:55]

Removed. Done

+    scoped_refptr<gpu::GpuChannelHost> gpu_channel =
+        gpu_->EstablishGpuChannelSync();
+    shared_main_thread_context_provider_ =
+        gpu_->CreateContextProvider(std::move(gpu_channel));
+    if (!shared_main_thread_context_provider_->BindToCurrentThread())
+      shared_main_thread_context_provider_ = nullptr;
+  }
+  return shared_main_thread_context_provider_;
 }
 
 void MusContextFactory::RemoveCompositor(ui::Compositor* compositor) {
   // NOTIMPLEMENTED();
 }
 
 double MusContextFactory::GetRefreshRate() const {
   return 60.0;
 }
 
 gpu::GpuMemoryBufferManager* MusContextFactory::GetGpuMemoryBufferManager() {
   return gpu_->gpu_memory_buffer_manager();
 }
 
 cc::TaskGraphRunner* MusContextFactory::GetTaskGraphRunner() {
   return raster_thread_helper_.task_graph_runner();
 }
 
 const cc::RendererSettings& MusContextFactory::GetRendererSettings() const {
   return renderer_settings_;
 }
 
 }  // namespace aura