Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 289033006: Don't try to access an Isolate when don't have one yet. (Closed)

Created:
6 years, 7 months ago by Sven Panne
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Don't try to access an Isolate when don't have one yet. BUG=373385 R=jochen@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/child/content_child_helpers.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Sven Panne
6 years, 7 months ago (2014-05-16 09:28:03 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-16 09:29:45 UTC) #2
Sven Panne
The CQ bit was checked by svenpanne@chromium.org
6 years, 7 months ago (2014-05-16 09:30:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/289033006/1
6 years, 7 months ago (2014-05-16 09:31:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 11:06:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 11:08:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/16994)
6 years, 7 months ago (2014-05-16 11:08:09 UTC) #7
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 7 months ago (2014-05-16 11:17:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svenpanne@chromium.org/289033006/1
6 years, 7 months ago (2014-05-16 11:17:31 UTC) #9
commit-bot: I haz the power
Change committed as 270986
6 years, 7 months ago (2014-05-16 11:18:19 UTC) #10
Michael Achenbach
6 years, 7 months ago (2014-05-16 11:22:20 UTC) #11
Message was sent while issue was closed.
In cases this gets reverted and also https://codereview.chromium.org/288193003/
lands in the mean time, it might cause the telemetry perf unittest to fail
again. See issue 373385.

Powered by Google App Engine
This is Rietveld 408576698