Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 289033002: Outputting command line if CreateProcess() fails. (Closed)

Created:
6 years, 7 months ago by huangs
Modified:
6 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Outputting command line if CreateProcess() fails. Specifically, this is to help us debug Win 8 Aura test flakes. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M base/process/launch_win.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
huangs
PTAL.
6 years, 7 months ago (2014-05-15 19:43:14 UTC) #1
huangs
OWNER review to thakis@.
6 years, 7 months ago (2014-05-16 22:35:57 UTC) #2
willchan no longer on Chromium
I think you may have missed this, but you keep picking reviewers who are traveling ...
6 years, 7 months ago (2014-05-16 22:59:19 UTC) #3
willchan no longer on Chromium
LGTM
6 years, 7 months ago (2014-05-16 23:00:32 UTC) #4
huangs
Ah yes; it's summer again. :) Thanks!
6 years, 7 months ago (2014-05-16 23:10:27 UTC) #5
huangs
The CQ bit was checked by huangs@chromium.org
6 years, 7 months ago (2014-05-16 23:15:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/huangs@chromium.org/289033002/1
6 years, 7 months ago (2014-05-16 23:33:37 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 14:47:32 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-18 14:00:16 UTC) #9
Message was sent while issue was closed.
Change committed as 271285

Powered by Google App Engine
This is Rietveld 408576698