Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionEditor.cpp

Issue 2890313003: Commands preserve handles (Closed)
Patch Set: Addressed yosin's comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/SelectionEditor.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
index a5c9762f04054f4ca7e0741333bc5f22732eb09a..4f3e990c05ddbcf6000daecd9eb15164a07658af 100644
--- a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
@@ -194,6 +194,7 @@ void SelectionEditor::NodeChildrenWillBeRemoved(ContainerNode& container) {
return;
selection_ = SelectionInDOMTree::Builder()
.SetBaseAndExtent(new_base, new_extent)
+ .SetIsHandleVisible(selection_.IsHandleVisible())
yosin_UTC9 2017/05/31 03:39:26 Good catch! (^_^)b
.Build();
MarkCacheDirty();
}
@@ -211,6 +212,7 @@ void SelectionEditor::NodeWillBeRemoved(Node& node_to_be_removed) {
return;
selection_ = SelectionInDOMTree::Builder()
.SetBaseAndExtent(new_base, new_extent)
+ .SetIsHandleVisible(selection_.IsHandleVisible())
.Build();
MarkCacheDirty();
}
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698