components/safe_browsing_db/test_database_manager.h - Issue 2890293004: Add the ability to check the CSD Whitelist asynchronously, for PhishGuard.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/test_database_manager.h

Issue 2890293004: Add the ability to check the CSD Whitelist asynchronously, for PhishGuard. (Closed)

Patch Set: Respond to vakhs review, fix up tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_browsing_db/test_database_manager.h

diff --git a/components/safe_browsing_db/test_database_manager.h b/components/safe_browsing_db/test_database_manager.h

index c2cd803fa9aaa3a016464cb7b8bafc1b77c62204..180723f002b17c2678c0a076d96fd6b4f4a26533 100644

--- a/components/safe_browsing_db/test_database_manager.h

+++ b/components/safe_browsing_db/test_database_manager.h

@@ -26,6 +26,7 @@ class TestSafeBrowsingDatabaseManager

bool CanCheckUrl(const GURL& url) const override;

bool ChecksAreAlwaysAsync() const override;

bool CheckBrowseUrl(const GURL& url, Client* client) override;

+ AsyncMatch CheckCsdWhitelistUrl(const GURL& url, Client* client) override;

bool CheckDownloadUrl(const std::vector<GURL>& url_chain,

Client* client) override;

bool CheckExtensionIDs(const std::set<std::string>& extension_ids,