Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: components/safe_browsing_db/remote_database_manager.cc

Issue 2890293004: Add the ability to check the CSD Whitelist asynchronously, for PhishGuard. (Closed)
Patch Set: Respond to vakhs review, fix up tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/safe_browsing_db/remote_database_manager.h" 5 #include "components/safe_browsing_db/remote_database_manager.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 base::Bind(&ClientRequest::OnRequestDoneWeak, req->GetWeakPtr()), url, 251 base::Bind(&ClientRequest::OnRequestDoneWeak, req->GetWeakPtr()), url,
252 {SB_THREAT_TYPE_SUBRESOURCE_FILTER}); 252 {SB_THREAT_TYPE_SUBRESOURCE_FILTER});
253 253
254 LogPendingChecks(current_requests_.size()); 254 LogPendingChecks(current_requests_.size());
255 current_requests_.push_back(req.release()); 255 current_requests_.push_back(req.release());
256 256
257 // Defer the resource load. 257 // Defer the resource load.
258 return false; 258 return false;
259 } 259 }
260 260
261 AsyncMatch RemoteSafeBrowsingDatabaseManager::CheckCsdWhitelistUrl(
262 const GURL& url,
263 Client* client) {
264 NOTREACHED();
265 return AsyncMatch::MATCH;
266 }
267
261 bool RemoteSafeBrowsingDatabaseManager::MatchCsdWhitelistUrl(const GURL& url) { 268 bool RemoteSafeBrowsingDatabaseManager::MatchCsdWhitelistUrl(const GURL& url) {
262 NOTREACHED(); 269 NOTREACHED();
263 return true; 270 return true;
264 } 271 }
265 272
266 bool RemoteSafeBrowsingDatabaseManager::MatchDownloadWhitelistString( 273 bool RemoteSafeBrowsingDatabaseManager::MatchDownloadWhitelistString(
267 const std::string& str) { 274 const std::string& str) {
268 NOTREACHED(); 275 NOTREACHED();
269 return true; 276 return true;
270 } 277 }
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 for (auto* req : to_callback) { 336 for (auto* req : to_callback) {
330 DVLOG(1) << "Stopping: Invoking unfinished req for URL " << req->url(); 337 DVLOG(1) << "Stopping: Invoking unfinished req for URL " << req->url();
331 req->OnRequestDone(SB_THREAT_TYPE_SAFE, ThreatMetadata()); 338 req->OnRequestDone(SB_THREAT_TYPE_SAFE, ThreatMetadata());
332 } 339 }
333 enabled_ = false; 340 enabled_ = false;
334 341
335 SafeBrowsingDatabaseManager::StopOnIOThread(shutdown); 342 SafeBrowsingDatabaseManager::StopOnIOThread(shutdown);
336 } 343 }
337 344
338 } // namespace safe_browsing 345 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698