components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc - Issue 2890253002: [subresource_filter] Move OnReloadRequested to the ChromeClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

Issue 2890253002: [subresource_filter] Move OnReloadRequested to the ChromeClient (Closed)

Patch Set: remove from the base class Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('K') | « components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc ('k') | components/subresource_filter/content/browser/subresource_filter_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

index 8793a243cf1a30bf04f9ec2a55193fd3ffcc0ca2..1d26c50282f70b005e16994a82201af18fbdc22f 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

@@ -178,7 +178,6 @@ class MockSubresourceFilterClient : public SubresourceFilterClient {

return whitelisted_hosts_.count(handle->GetURL().host());

}

- void WhitelistByContentSettings(const GURL& url) override {}

void WhitelistInCurrentWebContents(const GURL& url) override {

ASSERT_TRUE(url.SchemeIsHTTPOrHTTPS());

whitelisted_hosts_.insert(url.host());