Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2890193002: Make instrumentation data structure more regular (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, lukechurch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -66 lines) Patch
M pkg/analysis_server/tool/instrumentation/log/log.dart View 7 chunks +78 lines, -53 lines 0 comments Download
M pkg/analyzer/lib/instrumentation/instrumentation.dart View 2 chunks +9 lines, -10 lines 0 comments Download
M pkg/analyzer/test/instrumentation/instrumentation_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I realized that the plugin data had been added in two places, making it harder ...
3 years, 7 months ago (2017-05-18 15:40:27 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-18 16:03:42 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-18 16:09:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5659afc812b8725f8780d6e6573431865e4ef310 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698