Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2890173002: EQT: Record the max queueing time from navigation start to navigation away (Closed)
Patch Set: fix mock_renderer_scheduler Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
index 1578d3e96fd35054fb08c96a5aeb94ad7f759ff7..cad8b3a823b649298ca0e4a910aa508abc9bf0fb 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
@@ -220,6 +220,7 @@ RendererSchedulerImpl::MainThreadOnly::MainThreadOnly(
use_virtual_time(false),
is_audio_playing(false),
virtual_time_paused(false),
+ has_navigated(false),
rail_mode_observer(nullptr),
wake_up_budget_pool(nullptr),
task_duration_reporter("RendererScheduler.TaskDurationPerQueueType2"),
@@ -1646,6 +1647,12 @@ void RendererSchedulerImpl::RemovePendingNavigation(NavigatingFrameType type) {
}
}
+std::unique_ptr<base::SingleSampleMetric>
+RendererSchedulerImpl::CreateMaxQueueingTimeMetric() {
+ return base::SingleSampleMetricsFactory::Get()->CreateCustomCountsMetric(
+ "RendererScheduler.MaxQueueingTime", 1, 10000, 50);
+}
+
void RendererSchedulerImpl::OnNavigationStarted() {
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"),
"RendererSchedulerImpl::OnNavigationStarted");
@@ -1653,6 +1660,19 @@ void RendererSchedulerImpl::OnNavigationStarted() {
ResetForNavigationLocked();
}
+void RendererSchedulerImpl::OnCommitProvisionalLoad() {
+ // Initialize |max_queueing_time_metric| lazily so that
+ // |SingleSampleMetricsFactory::SetFactory()| is called before
+ // |SingleSampleMetricsFactory::Get()|
+ if (!GetMainThreadOnly().max_queueing_time_metric) {
+ GetMainThreadOnly().max_queueing_time_metric =
+ CreateMaxQueueingTimeMetric();
+ }
+ GetMainThreadOnly().max_queueing_time_metric.reset();
+ GetMainThreadOnly().max_queueing_time = base::TimeDelta();
+ GetMainThreadOnly().has_navigated = true;
+}
+
void RendererSchedulerImpl::OnFirstMeaningfulPaint() {
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"),
"RendererSchedulerImpl::OnFirstMeaningfulPaint");
@@ -1914,6 +1934,18 @@ void RendererSchedulerImpl::RemoveTaskTimeObserver(
void RendererSchedulerImpl::OnQueueingTimeForWindowEstimated(
base::TimeDelta queueing_time,
base::TimeTicks window_start_time) {
+ if (GetMainThreadOnly().has_navigated) {
+ if (GetMainThreadOnly().max_queueing_time < queueing_time) {
+ if (!GetMainThreadOnly().max_queueing_time_metric) {
+ GetMainThreadOnly().max_queueing_time_metric =
+ CreateMaxQueueingTimeMetric();
+ }
+ GetMainThreadOnly().max_queueing_time_metric->SetSample(
+ queueing_time.InMilliseconds());
+ GetMainThreadOnly().max_queueing_time = queueing_time;
+ }
+ }
+
// RendererScheduler reports the queueing time once per window's duration.
// |stepEQT|stepEQT|stepEQT|stepEQT|stepEQT|stepEQT|
// Report: |-------window EQT------|

Powered by Google App Engine
This is Rietveld 408576698