EQT: Record the max queueing time from navigation start to navigation away

content/renderer/render_frame_impl.cc

Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 8ff540e93bfe07d49b3cacacc4f1a6987ea39c47..6e13f1bd668df1b2ff0372abb2626269a77fe427 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3660,6 +3660,7 @@ void RenderFrameImpl::DidCommitProvisionalLoad(
           PageTransitionCoreTypeIs(navigation_state->GetTransitionType(),
                                    ui::PAGE_TRANSITION_RELOAD)) {
         render_thread_impl->GetRendererScheduler()->OnNavigationStarted();
+        render_thread_impl->GetRendererScheduler()->OnCommitProvisionalLoad();

[Charlie Reis, 2017/06/02 22:38:36]

Why do we need both?

[Liquan (Max) Gu, 2017/06/02 23:32:06]

There are two OnNavigationStarted(). One is this; another is in
RenderFrameImpl::OnNavigate(). By experiment, it shows that OnNavigate() is not
triggered from the second navigation of the same renderer, but this line is
triggered on every navigation start.

That's why we need a different signal from OnNavigationStarted().

I guess OnCommitProvisionalLoadAndNavigationStarted() will be more precise here,
based on the position of the code. Do you think so?

[Charlie Reis, 2017/06/05 05:02:34]

No, I think OnCommitProvisionalLoad was a better name.  (See my other comment
for more detail.)

My confusion here was why we still had OnNavigationStarted at all, since I
thought we were talking about removing it.  But looking closer, it looks like
you're hopefully planning to remove OnNavigationStarted in a followup CL as part
of https://crbug.com/726341.  If that's the case, I'm ok with it, but please
include a TODO to remove OnNavigationStarted (citing bug 726341).

[Liquan (Max) Gu, 2017/06/05 16:15:56]

Thanks for the detailed explanation. I have added a todo and will address
onNavigationStart in a followup CL.

       }
     }
   }