EQT: Record the max queueing time from navigation start to navigation away

third_party/WebKit/public/platform/scheduler/renderer/renderer_scheduler.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef THIRD_PARTY_WEBKIT_PUBLIC_PLATFORM_SCHEDULER_RENDERER_RENDERER_SCHEDULER_H_
 #define THIRD_PARTY_WEBKIT_PUBLIC_PLATFORM_SCHEDULER_RENDERER_RENDERER_SCHEDULER_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 135 matching lines @@
 
   // Tells the scheduler that a navigation task is no longer pending.
   // Must be called on the main thread.
   virtual void RemovePendingNavigation(NavigatingFrameType type) = 0;
 
   // Tells the scheduler that a navigation has started.  The scheduler will
   // prioritize loading tasks for a short duration afterwards.
   // Must be called from the main thread.
   virtual void OnNavigationStarted() = 0;
 
+  virtual void OnCommitProvisionalLoad() = 0;

[Charlie Reis, 2017/06/02 22:38:37]

This needs a comment, especially for how it differs from OnNavigationStarted. 
(I'm not clear why we need both, if they're called back-to-back.)

[Liquan (Max) Gu, 2017/06/02 23:32:06]

I am not sure about what "Commit Provisional Load" serve as a general purpose
and what it indicates, so I will call this function
OnCommitProvisionalLoadAndNavigationStarted() to be more precise, to indicate
this is signaling provisional load has been committed and navigation has
started. Is it OK?

[Charlie Reis, 2017/06/05 05:02:34]

No, sorry, I think that's more confusing.

I think we're just meaning different things when saying "navigation started." 
In the navigation logic, we refer to "start" as the time when the navigation's
network request is being made, which often unknown to the renderer process (even
more so with PlzNavigate).  "Commit" is the point at which the renderer process
starts parsing and rendering the new page, and it seems to me that's the point
in time that any renderer-side metrics should be interested in-- it's the point
that activity stops happening in the old page and starts happening in the new
page.

In that sense, I would expect us to remove OnNavigationStarted and only have
OnCommitProvisionalLoad.  If I'm following things correctly, that's the plan in
https://crbug.com/726341, and we can have comments and TODOs in this file to
that effect.

[Liquan (Max) Gu, 2017/06/05 16:15:56]

Thanks! 

+
   // Returns true if the scheduler has reason to believe that high priority work
   // may soon arrive on the main thread, e.g., if gesture events were observed
   // recently.
   // Must be called from the main thread.
   virtual bool IsHighPriorityWorkAnticipated() = 0;
 
   // Suspends the timer queues and increments the timer queue suspension count.
   // May only be called from the main thread.
   virtual void SuspendTimerQueue() = 0;
 
@@ skipping 35 matching lines @@
 
  protected:
   RendererScheduler();
   DISALLOW_COPY_AND_ASSIGN(RendererScheduler);
 };
 
 }  // namespace scheduler
 }  // namespace blink
 
 #endif  // THIRD_PARTY_WEBKIT_PUBLIC_PLATFORM_SCHEDULER_RENDERER_RENDERER_SCHEDULER_H_