Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2890163004: Add requestTime to responses (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -114 lines) Patch
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/domain_abstract_test.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 4 chunks +26 lines, -9 lines 0 comments Download
M pkg/analysis_server/tool/spec/generate_all.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 4 chunks +8 lines, -7 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol.dart View 5 chunks +23 lines, -38 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_generated.dart View 14 chunks +28 lines, -28 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/test/src/channel/isolate_channel_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_dart_protocol.dart View 4 chunks +26 lines, -9 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_protocol_common.dart View 2 chunks +10 lines, -6 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/generate_all.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This will allow server to see the latency in the plugins so that we can ...
3 years, 7 months ago (2017-05-18 16:08:44 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-18 17:05:52 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-18 17:32:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7e11a13cf52f7df16234e07c072cfba5ed9e8c9c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698