content/browser/renderer_host/render_widget_host_view_event_handler.cc - Issue 2890143003: Move ContextMenu show/hide state tracking to WebContents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_event_handler.cc

Issue 2890143003: Move ContextMenu show/hide state tracking to WebContents (Closed)

Patch Set: Remove #if def Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_event_handler.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_event_handler.cc b/content/browser/renderer_host/render_widget_host_view_event_handler.cc

index f0c1e1cbb08940c969609a249cd5d1efebbe7c67..995d2e51517b08fe8cd60d68ee6fbe67ec2447b1 100644

--- a/content/browser/renderer_host/render_widget_host_view_event_handler.cc

+++ b/content/browser/renderer_host/render_widget_host_view_event_handler.cc

@@ -577,7 +577,7 @@ bool RenderWidgetHostViewEventHandler::CanRendererHandleEvent(

// Don't forward the mouse leave message which is received when the context

// menu is displayed by the page. This confuses the page and causes state

// changes.

- if (host_view_->IsShowingContextMenu())

+ if (host_->delegate() && host_->delegate()->IsShowingContextMenuOnPage())

return false;

#endif

return true;