Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2890143003: Move ContextMenu show/hide state tracking to WebContents (Closed)
Patch Set: Fixing another compile error Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index e756ed927c5807b3e242f03cf8d4fd20604ea634..a5f91737a9fbdbe2507c32021acb4139e22f5ede 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -97,8 +97,6 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
ui::TextInputClient* GetTextInputClient() override;
void WasUnOccluded() override {}
void WasOccluded() override {}
- bool IsShowingContextMenu() const override;
- void SetShowingContextMenu(bool showing_menu) override;
void SetIsInVR(bool is_in_vr) override;
base::string16 GetSelectedText() override;
bool IsMouseLocked() override;
@@ -396,6 +394,11 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
// main frame.
virtual void OnDidNavigateMainFrameToNewPage();
+ // Called by WebContensImpl to notify the view about a change in visibility of
kenrb 2017/06/05 17:39:16 nit: WebContentsImpl
EhsanK 2017/06/06 12:34:46 Done.
+ // context menu. The view can then perform platform specific tasks and
+ // changes.
+ virtual void SetShowingContextMenu(bool showing) {}
+
// Add and remove observers for lifetime event notifications. The order in
// which notifications are sent to observers is undefined. Clients must be
// sure to remove the observer before they go away.
@@ -444,9 +447,6 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
// locked.
bool mouse_locked_;
- // Whether we are showing a context menu.
- bool showing_context_menu_;
-
// The scale factor of the display the renderer is currently on.
float current_device_scale_factor_;

Powered by Google App Engine
This is Rietveld 408576698