Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2890083002: Flatten futures when inferring the type of an async function expression. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Flatten futures when inferring the type of an async function expression. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a0d98fe474b622e28240cff03012057c5bfb6ec8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -3 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/testcases/inference/async_closure_return_type_flatten.dart View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/async_closure_return_type_flatten.dart.strong.expect View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-17 21:30:02 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-17 21:46:26 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-17 21:56:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a0d98fe474b622e28240cff03012057c5bfb6ec8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698