Issue 289007: GTK: disable theme buttons in options dialog when we are already using that t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 289007: GTK: disable theme buttons in options dialog when we are already using that t... (Closed)

Created:
11 years, 2 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
mattm

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

GTK: disable theme buttons in options dialog when we are already using that theme. BUG=18585 TEST=clicking Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29346

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -9 lines)			Patch
	M	chrome/browser/gtk/options/content_page_gtk.h	View	1	3 chunks	+14 lines, -0 lines	0 comments	Download
	M	chrome/browser/gtk/options/content_page_gtk.cc	View	1	4 chunks	+39 lines, -9 lines	0 comments	Download

Total messages: 4 (0 generated)

mattm

Probably want to send it to the linux_view and/or linux_chromeos try bots too http://codereview.chromium.org/289007/diff/1/2 File ...

11 years, 2 months ago (2009-10-16 20:59:27 UTC) #2

mattm

11 years, 2 months ago (2009-10-16 22:20:36 UTC) #4

lgtm once you fix the compile error

On 2009/10/16 21:58:45, Evan Stade wrote:
> good call, updated and trys sent