Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 289007: GTK: disable theme buttons in options dialog when we are already using that t... (Closed)

Created:
11 years, 2 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
mattm
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

GTK: disable theme buttons in options dialog when we are already using that theme. BUG=18585 TEST=clicking Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29346

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -9 lines) Patch
M chrome/browser/gtk/options/content_page_gtk.h View 1 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/gtk/options/content_page_gtk.cc View 1 4 chunks +39 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
11 years, 2 months ago (2009-10-16 20:45:53 UTC) #1
mattm
Probably want to send it to the linux_view and/or linux_chromeos try bots too http://codereview.chromium.org/289007/diff/1/2 File ...
11 years, 2 months ago (2009-10-16 20:59:27 UTC) #2
Evan Stade
good call, updated and trys sent
11 years, 2 months ago (2009-10-16 21:58:45 UTC) #3
mattm
11 years, 2 months ago (2009-10-16 22:20:36 UTC) #4
lgtm once you fix the compile error

On 2009/10/16 21:58:45, Evan Stade wrote:
> good call, updated and trys sent

Powered by Google App Engine
This is Rietveld 408576698