Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 289003007: Fix gin's array buffer class for component build (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix gin's array buffer class for component build Remove ArrayBuffer ctor that is not defined. Add explicit assignment operator for ArrayBufferView. BUG=none R=dcarney@chromium.org,mnaganov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M gin/array_buffer.h View 2 chunks +1 line, -1 line 0 comments Download
M gin/array_buffer.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-16 07:18:23 UTC) #1
mnaganov (inactive)
LGTM, thanks!
6 years, 7 months ago (2014-05-16 07:34:23 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-05-16 07:35:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/289003007/1
6 years, 7 months ago (2014-05-16 07:36:12 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 09:06:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 10:13:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154453)
6 years, 7 months ago (2014-05-16 10:13:56 UTC) #7
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-05-16 12:14:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/289003007/1
6 years, 7 months ago (2014-05-16 12:14:46 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 13:16:57 UTC) #10
Message was sent while issue was closed.
Change committed as 271003

Powered by Google App Engine
This is Rietveld 408576698