Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 289003006: Remove stray platform_file.h from webkit (Closed)

Created:
6 years, 7 months ago by rvargas (doing something else)
Modified:
6 years, 7 months ago
Reviewers:
kinuko, pfeldman
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org, nhiroki, tzik
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix Android build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M content/shell/app/shell_main_delegate.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/browser/blob/local_file_stream_reader.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_file_stream_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_url.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/browser/fileapi/isolated_file_system_backend.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_stream_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_stream_writer.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/quota/open_file_handle_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_stream_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/fileapi/file_system_util.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
rvargas (doing something else)
PTAL
6 years, 7 months ago (2014-05-16 19:31:09 UTC) #1
kinuko
lgtm
6 years, 7 months ago (2014-05-19 02:32:50 UTC) #2
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 7 months ago (2014-05-19 17:35:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/289003006/1
6 years, 7 months ago (2014-05-19 17:36:46 UTC) #4
commit-bot: I haz the power
Change committed as 271459
6 years, 7 months ago (2014-05-19 20:00:36 UTC) #5
rvargas (doing something else)
+pfeldman@ for content/shell: It looks some dependency changed between the trybots running and the first ...
6 years, 7 months ago (2014-05-20 00:53:05 UTC) #6
pfeldman
lgtm
6 years, 7 months ago (2014-05-20 13:00:17 UTC) #7
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 7 months ago (2014-05-20 18:10:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/289003006/20001
6 years, 7 months ago (2014-05-20 18:10:52 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 21:31:20 UTC) #10
Message was sent while issue was closed.
Change committed as 271756

Powered by Google App Engine
This is Rietveld 408576698