Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7557)

Unified Diff: chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h

Issue 2890023005: Chrome Cleaner UI: reporter no longer uses mojo. (Closed)
Patch Set: Add ChromeCleanerRunner class Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h
diff --git a/chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h b/chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h
index fe92d7c7c781f246f8c72201e7e1cc080d6540b4..e51fc90e04c30ce468c72d5b7b67925229d19a8c 100644
--- a/chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h
+++ b/chrome/browser/safe_browsing/chrome_cleaner/srt_chrome_prompt_impl.h
@@ -5,7 +5,12 @@
#ifndef CHROME_BROWSER_SAFE_BROWSING_CHROME_CLEANER_SRT_CHROME_PROMPT_IMPL_H_
#define CHROME_BROWSER_SAFE_BROWSING_CHROME_CLEANER_SRT_CHROME_PROMPT_IMPL_H_
+#include <memory>
+#include <set>
+#include <vector>
+
#include "base/callback.h"
+#include "base/files/file_path.h"
#include "base/macros.h"
#include "components/chrome_cleaner/public/interfaces/chrome_prompt.mojom.h"
#include "mojo/public/cpp/bindings/binding.h"
@@ -15,8 +20,13 @@ namespace safe_browsing {
// Implementation of the ChromePrompt Mojo interface.
class ChromePromptImpl : public chrome_cleaner::mojom::ChromePrompt {
public:
+ using OnPromptUserCallback = base::Callback<void(
ftirelo 2017/05/18 18:27:51 Shouldn't this be a OnceCallback as well, since it
alito 2017/05/18 23:01:17 Done.
+ std::unique_ptr<std::set<base::FilePath>>,
+ chrome_cleaner::mojom::ChromePrompt::PromptUserCallback callback)>;
ftirelo 2017/05/18 18:27:51 I'm afraid OnPromptUserCallback is too similar to
alito 2017/05/18 23:01:17 As discussed, using OnPromptUser for the type name
+
ChromePromptImpl(chrome_cleaner::mojom::ChromePromptRequest request,
- base::Closure on_connection_closed);
+ base::Closure on_connection_closed,
+ OnPromptUserCallback on_prompt_user);
~ChromePromptImpl() override;
void PromptUser(
@@ -27,6 +37,7 @@ class ChromePromptImpl : public chrome_cleaner::mojom::ChromePrompt {
private:
mojo::Binding<chrome_cleaner::mojom::ChromePrompt> binding_;
+ OnPromptUserCallback on_prompt_user_;
DISALLOW_COPY_AND_ASSIGN(ChromePromptImpl);
};

Powered by Google App Engine
This is Rietveld 408576698