Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Side by Side Diff: src/compiler/verifier.cc

Issue 2890023004: [turbofan] Avoid allocating rest parameters for spread calls. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/ia32/interface-descriptors-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 682 matching lines...) Expand 10 before | Expand all | Expand 10 after
693 case IrOpcode::kJSCreateScriptContext: { 693 case IrOpcode::kJSCreateScriptContext: {
694 // Type is Context, and operand is Internal. 694 // Type is Context, and operand is Internal.
695 Node* context = NodeProperties::GetContextInput(node); 695 Node* context = NodeProperties::GetContextInput(node);
696 // TODO(bmeurer): This should say CheckTypeIs, but we don't have type 696 // TODO(bmeurer): This should say CheckTypeIs, but we don't have type
697 // OtherInternal on certain contexts, i.e. those from OsrValue inputs. 697 // OtherInternal on certain contexts, i.e. those from OsrValue inputs.
698 CheckTypeMaybe(context, Type::OtherInternal()); 698 CheckTypeMaybe(context, Type::OtherInternal());
699 CheckTypeIs(node, Type::OtherInternal()); 699 CheckTypeIs(node, Type::OtherInternal());
700 break; 700 break;
701 } 701 }
702 702
703 case IrOpcode::kJSConstructForwardVarargs:
703 case IrOpcode::kJSConstruct: 704 case IrOpcode::kJSConstruct:
704 case IrOpcode::kJSConstructWithSpread: 705 case IrOpcode::kJSConstructWithSpread:
705 case IrOpcode::kJSConvertReceiver: 706 case IrOpcode::kJSConvertReceiver:
706 // Type is Receiver. 707 // Type is Receiver.
707 CheckTypeIs(node, Type::Receiver()); 708 CheckTypeIs(node, Type::Receiver());
708 break; 709 break;
709 case IrOpcode::kJSCallForwardVarargs: 710 case IrOpcode::kJSCallForwardVarargs:
710 case IrOpcode::kJSCall: 711 case IrOpcode::kJSCall:
711 case IrOpcode::kJSCallWithSpread: 712 case IrOpcode::kJSCallWithSpread:
712 case IrOpcode::kJSCallRuntime: 713 case IrOpcode::kJSCallRuntime:
(...skipping 1047 matching lines...) Expand 10 before | Expand all | Expand 10 after
1760 replacement->op()->EffectOutputCount() > 0); 1761 replacement->op()->EffectOutputCount() > 0);
1761 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1762 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1762 replacement->opcode() == IrOpcode::kFrameState); 1763 replacement->opcode() == IrOpcode::kFrameState);
1763 } 1764 }
1764 1765
1765 #endif // DEBUG 1766 #endif // DEBUG
1766 1767
1767 } // namespace compiler 1768 } // namespace compiler
1768 } // namespace internal 1769 } // namespace internal
1769 } // namespace v8 1770 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | src/ia32/interface-descriptors-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698