Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp

Issue 2890023003: [IndexedDB] Adding async tracing for renderer calls. (Closed)
Patch Set: fixed blink tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
index b4ef86ebd541d35a1901c67f721e482260c1e63e..99c276caf86ee313cee8c33b2ed5d1d9d2a56428 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
@@ -148,8 +148,10 @@ TEST_F(IDBTransactionTest, ContextDestroyedEarlyDeath) {
ThreadState::Current()->CollectAllGarbage();
EXPECT_EQ(1u, live_transactions.size());
- Persistent<IDBRequest> request = IDBRequest::Create(
- scope.GetScriptState(), IDBAny::CreateUndefined(), transaction_.Get());
+ Persistent<IDBRequest> request =
+ IDBRequest::Create(scope.GetScriptState(), IDBAny::CreateUndefined(),
+ transaction_.Get(), IDBRequest::AsyncTraceState());
+
DeactivateNewTransactions(scope.GetIsolate());
request.Clear(); // The transaction is holding onto the request.
@@ -178,8 +180,9 @@ TEST_F(IDBTransactionTest, ContextDestroyedAfterDone) {
ThreadState::Current()->CollectAllGarbage();
EXPECT_EQ(1U, live_transactions.size());
- Persistent<IDBRequest> request = IDBRequest::Create(
- scope.GetScriptState(), IDBAny::CreateUndefined(), transaction_.Get());
+ Persistent<IDBRequest> request =
+ IDBRequest::Create(scope.GetScriptState(), IDBAny::CreateUndefined(),
+ transaction_.Get(), IDBRequest::AsyncTraceState());
DeactivateNewTransactions(scope.GetIsolate());
// This response should result in an event being enqueued immediately.
@@ -216,8 +219,9 @@ TEST_F(IDBTransactionTest, ContextDestroyedWithQueuedResult) {
ThreadState::Current()->CollectAllGarbage();
EXPECT_EQ(1U, live_transactions.size());
- Persistent<IDBRequest> request = IDBRequest::Create(
- scope.GetScriptState(), IDBAny::CreateUndefined(), transaction_.Get());
+ Persistent<IDBRequest> request =
+ IDBRequest::Create(scope.GetScriptState(), IDBAny::CreateUndefined(),
+ transaction_.Get(), IDBRequest::AsyncTraceState());
DeactivateNewTransactions(scope.GetIsolate());
request->HandleResponse(CreateIDBValue(scope.GetIsolate(), true));
@@ -250,10 +254,12 @@ TEST_F(IDBTransactionTest, ContextDestroyedWithTwoQueuedResults) {
ThreadState::Current()->CollectAllGarbage();
EXPECT_EQ(1U, live_transactions.size());
- Persistent<IDBRequest> request1 = IDBRequest::Create(
- scope.GetScriptState(), IDBAny::CreateUndefined(), transaction_.Get());
- Persistent<IDBRequest> request2 = IDBRequest::Create(
- scope.GetScriptState(), IDBAny::CreateUndefined(), transaction_.Get());
+ Persistent<IDBRequest> request1 =
+ IDBRequest::Create(scope.GetScriptState(), IDBAny::CreateUndefined(),
+ transaction_.Get(), IDBRequest::AsyncTraceState());
+ Persistent<IDBRequest> request2 =
+ IDBRequest::Create(scope.GetScriptState(), IDBAny::CreateUndefined(),
+ transaction_.Get(), IDBRequest::AsyncTraceState());
DeactivateNewTransactions(scope.GetIsolate());
request1->HandleResponse(CreateIDBValue(scope.GetIsolate(), true));

Powered by Google App Engine
This is Rietveld 408576698