Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp

Issue 2890023003: [IndexedDB] Adding async tracing for renderer calls. (Closed)
Patch Set: fixed blink tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp
index 29c07634f929ebda4159350a7446af38d35ce624..8af2527d040f888f446f176859b94033eb8441a8 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp
@@ -65,6 +65,10 @@ static bool IsContextValid(ExecutionContext* context) {
IDBRequest* IDBFactory::GetDatabaseNames(ScriptState* script_state,
ExceptionState& exception_state) {
+ IDB_TRACE("IDBFactory::getDatabaseNamesRequestSetup");
+ IDBRequest::AsyncTraceState metrics("IDBFactory::getDatabaseNames", this);
+ IDBRequest* request = IDBRequest::Create(script_state, IDBAny::CreateNull(),
+ nullptr, std::move(metrics));
// TODO(jsbell): Used only by inspector; remove unneeded checks/exceptions?
if (!IsContextValid(ExecutionContext::From(script_state)))
return nullptr;
@@ -76,9 +80,6 @@ IDBRequest* IDBFactory::GetDatabaseNames(ScriptState* script_state,
return nullptr;
}
- IDBRequest* request =
- IDBRequest::Create(script_state, IDBAny::CreateNull(), nullptr);
-
if (!IndexedDBClient::From(ExecutionContext::From(script_state))
->AllowIndexedDB(ExecutionContext::From(script_state),
"Database Listing")) {
« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/IDBIndex.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698