[Interpreter] Handle various generator intrinsics

src/interpreter/interpreter-intrinsics-generator.cc

 // Copyright 2017 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/interpreter-intrinsics-generator.h"
 
 #include "src/allocation.h"
 #include "src/builtins/builtins.h"
 #include "src/code-factory.h"
 #include "src/frames.h"
@@ skipping 387 matching lines @@
 
   return value;
 }
 
 Node* IntrinsicsGenerator::CreateJSGeneratorObject(Node* input, Node* arg_count,
                                                    Node* context) {
   return IntrinsicAsBuiltinCall(input, context,
                                 Builtins::kCreateGeneratorObject);
 }
 
+Node* IntrinsicsGenerator::GeneratorGetContext(Node* args_reg, Node* arg_count,
+                                               Node* context) {
+  Node* generator = __ LoadRegister(args_reg);
+  Node* const value =
+      __ LoadObjectField(generator, JSGeneratorObject::kContextOffset);

[rmcilroy, 2017/05/17 14:48:28]

Maybe there is a case for having a LoadObjectField bytecode (which takes the
object in the accumulator and the offset as an operand) now which could be used
to implement all three of these intrinsics. WDYT?

[adamk, 2017/05/17 17:35:31]

I like this idea, I was curious why we didn't have something like this when I
started looking at generators last week. But I don't think it needs to hold up
this CL.

[mvstanton, 2017/05/18 10:00:59]

I'm happy to take a run at it. There are probably other cases to plug in
LoadObjectField too. It should make the bytecode smaller, right? (tryin' to
motivate myself :D)

+
+  return value;
+}
+
+Node* IntrinsicsGenerator::GeneratorGetInputOrDebugPos(Node* args_reg,
+                                                       Node* arg_count,
+                                                       Node* context) {
+  Node* generator = __ LoadRegister(args_reg);
+  Node* const value =
+      __ LoadObjectField(generator, JSGeneratorObject::kInputOrDebugPosOffset);
+
+  return value;
+}
+
+Node* IntrinsicsGenerator::GeneratorGetResumeMode(Node* args_reg,
+                                                  Node* arg_count,
+                                                  Node* context) {
+  Node* generator = __ LoadRegister(args_reg);
+  Node* const value =
+      __ LoadObjectField(generator, JSGeneratorObject::kResumeModeOffset);
+
+  return value;
+}
+
 Node* IntrinsicsGenerator::AsyncGeneratorReject(Node* input, Node* arg_count,
                                                 Node* context) {
   return IntrinsicAsBuiltinCall(input, context,
                                 Builtins::kAsyncGeneratorReject);
 }
 
 Node* IntrinsicsGenerator::AsyncGeneratorResolve(Node* input, Node* arg_count,
                                                  Node* context) {
   return IntrinsicAsBuiltinCall(input, context,
                                 Builtins::kAsyncGeneratorResolve);
 }
 
 void IntrinsicsGenerator::AbortIfArgCountMismatch(int expected, Node* actual) {
   InterpreterAssembler::Label match(assembler_);
   Node* comparison = __ Word32Equal(actual, __ Int32Constant(expected));
   __ GotoIf(comparison, &match);
   __ Abort(kWrongArgumentCountForInvokeIntrinsic);
   __ Goto(&match);
   __ Bind(&match);
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8